Page MenuHomePhabricator

phabricator: handle exceptions better
ClosedPublic

Authored by mjpieters on Oct 19 2017, 8:26 AM.

Details

Reviewers
ikostia
Group Reviewers
Restricted Project
Commits
rFBHGXda5e151b1aa5: phabricator: handle exceptions better
Summary

The error number is only present on *some* exceptions, and only on the wrapped
argument, like SSLError() wrapping a IOError exception.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mjpieters created this revision.Oct 19 2017, 8:26 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2017, 8:26 AM
mjpieters retitled this revision from phabritor: handle exceptions better to phabricator: handle exceptions better.Oct 19 2017, 8:29 AM
mjpieters added a reviewer: ikostia.

This doesn't fix the actual SSL error that lead to this issue; that'll be a separate fix where we pass in the web.cacerts config option to the client so we can use the configured certificates.

ikostia accepted this revision.Oct 19 2017, 8:58 AM
This revision is now accepted and ready to land.Oct 19 2017, 8:58 AM
This revision was automatically updated to reflect the committed changes.