This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12138

branchmap: split a long condition in branchcache.validfor(), add comments
ClosedPublic

Authored by av6 on Feb 7 2022, 8:01 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG02e9ad08999b: branchmap: split a long condition in branchcache.validfor(), add comments

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

av6 created this revision.Feb 7 2022, 8:01 AM
Alphare accepted this revision.Feb 7 2022, 8:45 AM
This revision is now accepted and ready to land.Feb 7 2022, 8:45 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/branchmap.py (22 lines)

Diff 32085

mercurial/branchmap.py

def _filename(repo): def _filename(repo):
"""name of a branchcache file for a given repo or repoview""" """name of a branchcache file for a given repo or repoview"""
filename = b"branch2" filename = b"branch2"
if repo.filtername: if repo.filtername:
filename = b'%s-%s' % (filename, repo.filtername) filename = b'%s-%s' % (filename, repo.filtername)
return filename return filename
def validfor(self, repo): def validfor(self, repo):
"""Is the cache content valid regarding a repo """check that cache contents are valid for (a subset of) this repo
- False when cached tipnode is unknown or if we detect a strip. - False when the order of changesets changed or if we detect a strip.
- True when cache is up to date or a subset of current repo.""" - True when cache is up-to-date for the current repo or its subset."""
try: try:
return (self.tipnode == repo.changelog.node(self.tiprev)) and ( node = repo.changelog.node(self.tiprev)
self.filteredhash
== scmutil.filteredhash(repo, self.tiprev, needobsolete=True)
)
except IndexError: except IndexError:
# changesets were stripped and now we don't even have enough to
# find tiprev
return False
if self.tipnode != node:
# tiprev doesn't correspond to tipnode: repo was stripped, or this
# repo has a different order of changesets
return False return False
tiphash = scmutil.filteredhash(repo, self.tiprev, needobsolete=True)
# hashes don't match if this repo view has a different set of filtered
# revisions (e.g. due to phase changes) or obsolete revisions (e.g.
# history was rewritten)
return self.filteredhash == tiphash
def _branchtip(self, heads): def _branchtip(self, heads):
"""Return tuple with last open head in heads and false, """Return tuple with last open head in heads and false,
otherwise return last closed head and true.""" otherwise return last closed head and true."""
tip = heads[-1] tip = heads[-1]
closed = True closed = True
for h in reversed(heads): for h in reversed(heads):
if h not in self._closednodes: if h not in self._closednodes: