This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12143

rank: compute property incrementally
ClosedPublic

Authored by pacien on Feb 7 2022, 12:25 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG580660518459: rank: compute property incrementally
Summary

This replaces the naive rank computation with a more efficient incremental
method, avoiding computing the whole ancestor set when possible.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pacien created this revision.Feb 7 2022, 12:25 PM
Alphare accepted this revision.Feb 8 2022, 10:33 AM
This revision is now accepted and ready to land.Feb 8 2022, 10:33 AM
pacien edited the summary of this revision. (Show Details)Feb 14 2022, 12:07 PM
pacien updated this revision to Diff 32171.
pacien added a commit: rHG580660518459: rank: compute property incrementally.Feb 15 2022, 9:48 AM
Closed by commit rHG580660518459: rank: compute property incrementally (authored by pacien). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (11 lines)

Diff 32204

mercurial/revlog.py

serialized_sidedata = b"" serialized_sidedata = b""
# Don't store the offset if the sidedata is empty, that way # Don't store the offset if the sidedata is empty, that way
# we can easily detect empty sidedata and they will be no different # we can easily detect empty sidedata and they will be no different
# than ones we manually add. # than ones we manually add.
sidedata_offset = 0 sidedata_offset = 0
rank = RANK_UNKNOWN rank = RANK_UNKNOWN
if self._format_version == CHANGELOGV2: if self._format_version == CHANGELOGV2:
rank = len(list(self.ancestors([p1r, p2r], inclusive=True))) + 1 if (p1r, p2r) == (nullrev, nullrev):
rank = 1
elif p1r != nullrev and p2r == nullrev:
rank = 1 + self.fast_rank(p1r)
elif p1r == nullrev and p2r != nullrev:
rank = 1 + self.fast_rank(p2r)
else: # merge node
pmin, pmax = sorted((p1r, p2r))
rank = 1 + self.fast_rank(pmax)
rank += sum(1 for _ in self.findmissingrevs([pmax], [pmin]))
e = revlogutils.entry( e = revlogutils.entry(
flags=flags, flags=flags,
data_offset=offset, data_offset=offset,
data_compressed_length=deltainfo.deltalen, data_compressed_length=deltainfo.deltalen,
data_uncompressed_length=textlen, data_uncompressed_length=textlen,
data_compression_mode=compression_mode, data_compression_mode=compression_mode,
data_delta_base=deltainfo.base, data_delta_base=deltainfo.base,