This is an archive of the discontinued Mercurial Phabricator instance.

dirstate-v2: fix infinite loop in pure packer
ClosedPublic

Authored by Alphare on Feb 11 2022, 6:27 PM.

Details

Summary

Due to the naive approach to path relative-ness, some tree shapes
like the one introduced in the associated test could result in the
packer going into an endless loop which allocated new Node objects
endlessly until the process was killed by Linux's OOM killer.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Feb 11 2022, 6:27 PM
SimonSapin accepted this revision.Feb 12 2022, 3:08 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.