This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1220

perf-test-for-D1208: testing code for the cache related changes in D1208
AbandonedPublic

Authored by singhsrb on Oct 23 2017, 4:18 PM.

Download Raw Diff

Details

Reviewers

durham

Group Reviewers

Restricted Project

Summary

Just putting this commit out there to share how I tested the
performance for D1208.

Test Plan

Ran 'test-cstore.t' with and without D1208 patched.

Around 0.50 seconds with D1208.
Around 4 seconds without D1208.

Diff Detail

Repository

rFBHGX Facebook Mercurial Extensions

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

singhsrb created this revision.Oct 23 2017, 4:18 PM

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2017, 4:18 PM

No need to review this. I will abandon this eventually or use it properly for testing.

singhsrb mentioned this in D1208: basepack: add a lru cache for the pack files.Oct 23 2017, 4:21 PM

Could we make this an actual test of some sort? Maybe monkey patch the iter function to count how many times it iterates and assert that it only iterates N + 1 times (for N packs)

This revision now requires changes to proceed.Oct 26 2017, 4:14 PM

This commit was only there to show how I tested the performance. The actual test for the cache is in D1208 itself. Therefore, abandoning this revision!

Revision Contents
Changeset List

			Path	Packages
M			tests/cstore-datapackstore.py (42 lines)

Diff 3070

tests/cstore-datapackstore.py

	#!/usr/bin/env python2.7			#!/usr/bin/env python2.7

				import copy
	import hashlib			import hashlib
	import os			import os
	import random			import random
	import shutil			import shutil
	import sys			import sys
	import tempfile			import tempfile
	import time			import time
	import unittest			import unittest

	import silenttestrunner			import silenttestrunner

				from timeit import default_timer as timer
	# Load the local cstore, not the system one			# Load the local cstore, not the system one
	fullpath = os.path.join(os.getcwd(), __file__)			fullpath = os.path.join(os.getcwd(), __file__)
	sys.path.insert(0, os.path.dirname(os.path.dirname(fullpath)))			sys.path.insert(0, os.path.dirname(os.path.dirname(fullpath)))

	from cstore import (			from cstore import (
	datapackstore,			datapackstore,
	)			)

	from remotefilelog.datapack import (			from remotefilelog.datapack import (
				datapackstore as correctstore,
	fastdatapack,			fastdatapack,
	mutabledatapack,			mutabledatapack,
	)			)

	from mercurial.node import nullid			from mercurial.node import nullid
	import mercurial.ui			import mercurial.ui

	class datapackstoretests(unittest.TestCase):			class datapackstoretests(unittest.TestCase):
	packer = mutabledatapack(mercurial.ui.ui(), packdir)			packer = mutabledatapack(mercurial.ui.ui(), packdir)

	for filename, node, base, content in revisions:			for filename, node, base, content in revisions:
	packer.add(filename, node, base, content)			packer.add(filename, node, base, content)

	path = packer.close()			path = packer.close()
	return fastdatapack(path)			return fastdatapack(path)

				def testGetDeltaChainPerf(self):
				"""Test the performance of fetching the delta chain."""
				packdir = self.makeTempDir()
				numfiles = 200
				numlines = 100
				revisions = []

				for i in range(numfiles):
				revisionlist = []
				revision = (str(i), self.getFakeHash(), nullid, "content")

				for j in range(numlines):
				revisionlist.append(revision)
				revision = (
				str(i),
				self.getFakeHash(),
				revision[1],
				self.getFakeHash()
				)

				self.createPack(packdir, revisions=revisionlist)
				revisions.append(revisionlist)

				store = correctstore(mercurial.ui.ui(), packdir, True)

				totaltime = 0
				random.shuffle(revisions)
				for l in revisions:
				oldlist = copy.deepcopy(l)
				random.shuffle(l)
				for r in l:
				start = timer()
				chain = store.getdeltachain(r[0], r[1])
				totaltime += timer() - start
				self.assertEquals(oldlist.index(r) + 1, len(chain))

				sys.stdout.write('%s seconds\n' % str(totaltime))
				sys.stdout.flush()

	def testGetDeltaChainSingleRev(self):			def testGetDeltaChainSingleRev(self):
	"""Test getting a 1-length delta chain."""			"""Test getting a 1-length delta chain."""
	packdir = self.makeTempDir()			packdir = self.makeTempDir()

	revisions = [("foo", self.getFakeHash(), nullid, "content")]			revisions = [("foo", self.getFakeHash(), nullid, "content")]
	self.createPack(packdir, revisions=revisions)			self.createPack(packdir, revisions=revisions)

	store = datapackstore(packdir)			store = datapackstore(packdir)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3070			Oct 23 2017, 4:18 PM	★	★