This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12355

revlog: remove unused `rank` variable from D12209
ClosedPublic

Authored by martinvonz on Mar 4 2022, 4:02 PM.

Details

Reviewers
pacien
indygreg
Group Reviewers
hg-reviewers
Commits
rHG4bb04a506af6: revlog: remove unused `rank` variable from D12209

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Mar 4 2022, 4:02 PM
pacien accepted this revision.Mar 4 2022, 9:27 PM
pacien added a subscriber: pacien.

Good catch.

indygreg accepted this revision.Mar 8 2022, 9:53 PM
This revision is now accepted and ready to land.Mar 8 2022, 9:53 PM
martinvonz added a commit: rHG4bb04a506af6: revlog: remove unused `rank` variable from D12209.Mar 8 2022, 9:58 PM
Closed by commit rHG4bb04a506af6: revlog: remove unused `rank` variable from D12209 (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/revlog.c (1 line)

Diff 32605

mercurial/cext/revlog.c

* *
* This method returns the rank retrieved from the revlog in constant time. It * This method returns the rank retrieved from the revlog in constant time. It
* makes no attempt at computing unknown values for versions of the revlog * makes no attempt at computing unknown values for versions of the revlog
* which do not persist the rank. * which do not persist the rank.
*/ */
static int index_fast_rank(indexObject *self, Py_ssize_t pos) static int index_fast_rank(indexObject *self, Py_ssize_t pos)
{ {
Py_ssize_t length = index_length(self); Py_ssize_t length = index_length(self);
int rank;
if (self->format_version != format_cl2 || pos >= length) { if (self->format_version != format_cl2 || pos >= length) {
return rank_unknown; return rank_unknown;
} }
if (pos == nullrev) { if (pos == nullrev) {
return 0; /* convention */ return 0; /* convention */
} }