( )⚙ D12373 rust-hg-core: use correct type for libc hostname buffer

This is an archive of the discontinued Mercurial Phabricator instance.

rust-hg-core: use correct type for libc hostname buffer
ClosedPublic

Authored by lukegb on Mar 14 2022, 10:11 AM.

Details

Summary

The type of libc::c_char is u8 on aarch64 rather than i8, which causes
the use of a specifically-typed constant to fail.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

lukegb created this revision.Mar 14 2022, 10:11 AM

I'm pulling this patch into nixpkgs directly (https://github.com/NixOS/nixpkgs/pull/164119) as well just to unblock us (and also to actually test this on an aarch64-linux system, since I don't have one to hand but we do have them in CI)

lukegb updated this revision to Diff 32636.Mar 14 2022, 10:20 AM
Alphare accepted this revision.Mar 14 2022, 10:23 AM
This revision is now accepted and ready to land.Mar 14 2022, 10:23 AM
This revision was automatically updated to reflect the committed changes.