This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12389

rhg: sort unsupported extensions in error message
ClosedPublic

Authored by Alphare on Sat, Mar 19, 10:46 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGc75dae6e4ca7: rhg: sort unsupported extensions in error message
Summary

This caused some flakiness in test output, and is also just better for users.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Sat, Mar 19, 10:46 AM
Alphare added a commit: rHGc75dae6e4ca7: rhg: sort unsupported extensions in error message.Fri, Mar 25, 11:43 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGc75dae6e4ca7: rhg: sort unsupported extensions in error message (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/rhg/src/main.rs (3 lines)

Diff 32711

rust/rhg/src/main.rs

for ignored in ignored_list { for ignored in ignored_list {
unsupported.remove(ignored.as_slice()); unsupported.remove(ignored.as_slice());
} }
} }
if unsupported.is_empty() { if unsupported.is_empty() {
Ok(()) Ok(())
} else { } else {
let mut unsupported: Vec<_> = unsupported.into_iter().collect();
// Sort the extensions to get a stable output
unsupported.sort();
Err(CommandError::UnsupportedFeature { Err(CommandError::UnsupportedFeature {
message: format_bytes!( message: format_bytes!(
b"extensions: {} (consider adding them to 'rhg.ignored-extensions' config)", b"extensions: {} (consider adding them to 'rhg.ignored-extensions' config)",
join(unsupported, b", ") join(unsupported, b", ")
), ),
}) })
} }
} }