This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12602

test-dirstate: print something when the check is skipped
ClosedPublic

Authored by Alphare on Wed, May 4, 9:55 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG682b0ac92c0b: test-dirstate: print something when the check is skipped
Summary

This makes a programming error obvious in cases when it should not be skipped

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Wed, May 4, 9:55 AM
Alphare added a commit: rHG682b0ac92c0b: test-dirstate: print something when the check is skipped.Wed, May 4, 10:24 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG682b0ac92c0b: test-dirstate: print something when the check is skipped (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.
baymax updated this revision to Diff 33352.Wed, May 4, 10:52 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)
⚠ This patch is intended for stable ⚠

Revision Contents
Changeset List

PathPackages
Mtests/test-dirstate.t (5 lines)

Diff 33345

tests/test-dirstate.t

$ find_dirstate_uuid () { $ find_dirstate_uuid () {
> hg debugstate --docket | grep uuid | sed 's/.*uuid: \(.*\)/\1/' > hg debugstate --docket | grep uuid | sed 's/.*uuid: \(.*\)/\1/'
> } > }
$ dirstate_uuid_has_not_changed () { $ dirstate_uuid_has_not_changed () {
> # Non-Rust always rewrites the whole dirstate > # Non-Rust always rewrites the whole dirstate
> if [ $# -eq 1 ] || ([ -n "$HGMODULEPOLICY" ] && [ -z "${HGMODULEPOLICY##*rust*}" ]) || [ -n "$RHG_INSTALLED_AS_HG" ]; then > if [ $# -eq 1 ] || ([ -n "$HGMODULEPOLICY" ] && [ -z "${HGMODULEPOLICY##*rust*}" ]) || [ -n "$RHG_INSTALLED_AS_HG" ]; then
> test $current_uid = $(find_dirstate_uuid) > test $current_uid = $(find_dirstate_uuid)
> else
> echo "not testing because using Python implementation"
> fi > fi
> } > }
$ cd .. $ cd ..
$ hg init append-mostly $ hg init append-mostly
$ cd append-mostly $ cd append-mostly
$ mkdir dir dir2 $ mkdir dir dir2
$ touch dir/a dir/b dir/c dir/d dir/e dir2/f $ touch dir/a dir/b dir/c dir/d dir/e dir2/f
$ hg commit -Aqm initial $ hg commit -Aqm initial
$ hg st $ hg st
$ dirstate_data_files | wc -l $ dirstate_data_files | wc -l
*1 (re) *1 (re)
$ current_uid=$(find_dirstate_uuid) $ current_uid=$(find_dirstate_uuid)
Nothing changes here Nothing changes here
$ hg st $ hg st
$ dirstate_data_files | wc -l $ dirstate_data_files | wc -l
*1 (re) *1 (re)
$ dirstate_uuid_has_not_changed $ dirstate_uuid_has_not_changed
not testing because using Python implementation (no-rust no-rhg !)
Trigger an append with a small change Trigger an append with a small change
$ echo "modified" > dir2/f $ echo "modified" > dir2/f
$ hg st $ hg st
M dir2/f M dir2/f
$ dirstate_data_files | wc -l $ dirstate_data_files | wc -l
*1 (re) *1 (re)
$ dirstate_uuid_has_not_changed $ dirstate_uuid_has_not_changed
not testing because using Python implementation (no-rust no-rhg !)
Unused bytes counter is non-0 when appending Unused bytes counter is non-0 when appending
$ touch file $ touch file
$ hg add file $ hg add file
$ current_uid=$(find_dirstate_uuid) $ current_uid=$(find_dirstate_uuid)
Trigger a rust/rhg run which updates the unused bytes value Trigger a rust/rhg run which updates the unused bytes value
$ hg st $ hg st
M dir2/f M dir2/f
A file A file
$ dirstate_data_files | wc -l $ dirstate_data_files | wc -l
*1 (re) *1 (re)
$ dirstate_uuid_has_not_changed $ dirstate_uuid_has_not_changed
not testing because using Python implementation (no-rust no-rhg !)
$ hg debugstate --docket | grep unused $ hg debugstate --docket | grep unused
number of unused bytes: 0 (no-rust no-rhg !) number of unused bytes: 0 (no-rust no-rhg !)
number of unused bytes: [1-9]\d* (re) (rhg no-rust !) number of unused bytes: [1-9]\d* (re) (rhg no-rust !)
number of unused bytes: [1-9]\d* (re) (rust no-rhg !) number of unused bytes: [1-9]\d* (re) (rust no-rhg !)
number of unused bytes: [1-9]\d* (re) (rust rhg !) number of unused bytes: [1-9]\d* (re) (rust rhg !)
Delete most of the dirstate to trigger a non-append Delete most of the dirstate to trigger a non-append