This is an archive of the discontinued Mercurial Phabricator instance.

rust-dirstate-v2: show `unused_bytes` counter is not reset on total rewrite
ClosedPublic

Authored by Alphare on Apr 28 2022, 11:16 AM.

Details

Summary

This was picked up by @aalekseyev when doing unrelated debugging.

The Rust implementation was never resetting this counter, so a brand new file
would carry over the old counter.

As I write this, my counter is a supposed 7389089 unused bytes for a total of
170978 bytes in the data file. Feel free to post your own high score.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Apr 28 2022, 11:16 AM
marmoute accepted this revision.Tue, May 3, 12:39 PM

I recommend that you play vex 6.

av6 requested changes to this revision.Wed, May 4, 7:28 AM
av6 added a subscriber: av6.
av6 added inline comments.
tests/test-dirstate.t
178

Could you update this real quick to have dirstate_data_files | wc -l before this line? To make your comment in D12592 accurate.

This revision now requires changes to proceed.Wed, May 4, 7:28 AM
Alphare updated this revision to Diff 33335.Wed, May 4, 9:55 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.
baymax updated this revision to Diff 33349.Wed, May 4, 10:52 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)
⚠ This patch is intended for stable ⚠