This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12593

rust-dirstate-v2: show `unused_bytes` counter is not reset on total rewrite
ClosedPublic

Authored by Alphare on Apr 28 2022, 11:16 AM.

Details

Reviewers
marmoute
av6
Group Reviewers
hg-reviewers
Commits
rHGc69adc82e7f7: rust-dirstate-v2: show `unused_bytes` counter is not reset on total rewrite
Summary

This was picked up by @aalekseyev when doing unrelated debugging.

The Rust implementation was never resetting this counter, so a brand new file
would carry over the old counter.

As I write this, my counter is a supposed 7389089 unused bytes for a total of
170978 bytes in the data file. Feel free to post your own high score.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Apr 28 2022, 11:16 AM
marmoute accepted this revision.Tue, May 3, 12:39 PM
romimichal99 added a subscriber: romimichal99.Tue, May 3, 11:23 PM

I recommend that you play vex 6.

av6 requested changes to this revision.Wed, May 4, 7:28 AM
av6 added a subscriber: av6.
av6 added inline comments.
tests/test-dirstate.t
178

Could you update this real quick to have dirstate_data_files | wc -l before this line? To make your comment in D12592 accurate.

This revision now requires changes to proceed.Wed, May 4, 7:28 AM
Alphare updated this revision to Diff 33335.Wed, May 4, 9:55 AM
Alphare added a commit: rHGc69adc82e7f7: rust-dirstate-v2: show `unused_bytes` counter is not reset on total rewrite.Wed, May 4, 10:24 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGc69adc82e7f7: rust-dirstate-v2: show `unused_bytes` counter is not reset on total rewrite (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.
baymax updated this revision to Diff 33349.Wed, May 4, 10:52 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)
⚠ This patch is intended for stable ⚠

Revision Contents
Changeset List

PathPackages
Mtests/test-dirstate.t (28 lines)

Diff 33342

tests/test-dirstate.t

$ echo "modified" > dir2/f $ echo "modified" > dir2/f
$ hg st $ hg st
M dir2/f M dir2/f
$ dirstate_data_files | wc -l $ dirstate_data_files | wc -l
*1 (re) *1 (re)
$ dirstate_uuid_has_not_changed $ dirstate_uuid_has_not_changed
Unused bytes counter is non-0 when appending
$ touch file
$ hg add file
$ current_uid=$(find_dirstate_uuid)
Trigger a rust/rhg run which updates the unused bytes value
$ hg st
M dir2/f
A file
$ dirstate_data_files | wc -l
av6Unsubmitted
Not Done

Could you update this real quick to have dirstate_data_files | wc -l before this line? To make your comment in D12592 accurate.

av6: Could you update this real quick to have `dirstate_data_files | wc -l` before this line? To…
*1 (re)
$ dirstate_uuid_has_not_changed
$ hg debugstate --docket | grep unused
number of unused bytes: 0 (no-rust no-rhg !)
number of unused bytes: [1-9]\d* (re) (rhg no-rust !)
number of unused bytes: [1-9]\d* (re) (rust no-rhg !)
number of unused bytes: [1-9]\d* (re) (rust rhg !)
Delete most of the dirstate to trigger a non-append Delete most of the dirstate to trigger a non-append
$ hg rm dir/a dir/b dir/c dir/d $ hg rm dir/a dir/b dir/c dir/d
$ dirstate_data_files | wc -l $ dirstate_data_files | wc -l
*1 (re) *1 (re)
$ dirstate_uuid_has_not_changed also-if-python $ dirstate_uuid_has_not_changed also-if-python
[1] [1]
$ cd .. Check that unused bytes counter is reset when creating a new docket
$ hg debugstate --docket | grep unused
number of unused bytes: 0 (no-rust !)
number of unused bytes: [1-9]\d* (re) (rust known-bad-output !)
#endif #endif
$ cd ..