This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1261

rage: include contents of packdirs
ClosedPublic

Authored by phillco on Oct 27 2017, 8:35 PM.
Tags
None
Subscribers
durham

Details

Reviewers
durham
Group Reviewers
Restricted Project
Commits
rFBHGX213c9ab02ed8: rage: include contents of packdirs
Summary

Example output:

shared packs (files):
---------------------------
/var/cache/hgcache/fbsource/packs:
total 64K
drwxrwsr-x. 2 phillco svnuser 36K Oct 26 14:09 manifests
...

shared packs (trees):
---------------------------
/var/cache/hgcache/fbsource/packs/manifests:
total 741M
-r--r--r--. 1 phillco svnuser 1.8K Oct  9 00:37 0a0d759b468bf3766b1596d133d7dcf5c55db702.dataidx
-r--r--r--. 1 phillco svnuser  77K Oct  9 00:37 0a0d759b468bf3766b1596d133d7dcf5c55db702.datapack
-r--r--r--. 1 phillco svnuser  33K Oct  9 12:54 0b233c54960ad32a75238334b18bdb8176b95dae.dataidx
-r--r--r--. 1 phillco svnuser 1.7M Oct  9 12:54 0b233c54960ad32a75238334b18bdb8176b95dae.datapack
-r--r--r--. 1 phillco svnuser  74K Oct  8 23:40 0b33a64b257bee2583ded9d38f13404f52a33670.dataidx
...

local packs (files):
---------------------------
/data/users/phillco/fbsource/.hg/store/packs/:
total 856K
drwxrwsr-x. 2 phillco svnuser 856K Oct 26 14:14 manifests


local packs (trees):
---------------------------
/data/users/phillco/fbsource/.hg/store/packs/manifests:
total 27M
-r--r--r--. 1 phillco svnuser 1.2K Oct  3 13:37 000004931915fa871abb373503d0e8656f543d59.dataidx
-r--r--r--. 1 phillco svnuser 4.4K Oct  3 13:37 000004931915fa871abb373503d0e8656f543d59.datapack
-r--r--r--. 1 phillco svnuser 1.2K Oct  3 13:34 0009e3182c6268d64a3c6d9cb79ba74a0f5e3fa2.dataidx
-r--r--r--. 1 phillco svnuser 3.1K Oct  3 13:34 0009e3182c6268d64a3c6d9cb79ba74a0f5e3fa2.datapack
...

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

phillco created this revision.Oct 27 2017, 8:35 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 27 2017, 8:35 PM
durham accepted this revision.Oct 28 2017, 3:42 PM
durham added a subscriber: durham.

Could you include some example output in the test plan?

hgext3rd/rage.py
33

I'd use the multi-line format, like above. I thought there was a lint rule about this, but maybe not.

This revision is now accepted and ready to land.Oct 28 2017, 3:42 PM
phillco edited the summary of this revision. (Show Details)Oct 30 2017, 11:46 PM
phillco updated this revision to Diff 3165.
phillco marked an inline comment as done.Oct 30 2017, 11:47 PM
phillco closed this revision.

Revision Contents
Changeset List

PathPackages
Mhgext3rd/rage.py (23 lines)
Mremotefilelog/constants.py (2 lines)

Diff 3165

hgext3rd/rage.py

sparse, sparse,
) )
from phabricator import ( from phabricator import (
arcconfig, arcconfig,
conduit, conduit,
) )
import os, socket, re, tempfile, time, traceback import os, socket, re, tempfile, time, traceback
from remotefilelog import (
durhamUnsubmitted
Done

I'd use the multi-line format, like above. I thought there was a lint rule about this, but maybe not.

durham: I'd use the multi-line format, like above. I thought there was a lint rule about this, but…
constants,
shallowutil
)
cmdtable = {} cmdtable = {}
command = registrar.command(cmdtable) command = registrar.command(cmdtable)
_failsafeerrors = [] _failsafeerrors = []
def _failsafe(func): def _failsafe(func):
try: try:
return func() return func()
lambda: shcmd('/System/Library/PrivateFrameworks/Apple80211.' + lambda: shcmd('/System/Library/PrivateFrameworks/Apple80211.' +
'framework/Versions/Current/Resources/airport ' + 'framework/Versions/Current/Resources/airport ' +
'--getinfo', check=False))), '--getinfo', check=False))),
('hg debugobsolete <smartlog>', ('hg debugobsolete <smartlog>',
_failsafe(lambda: obsoleteinfo(repo, hgcmd))), _failsafe(lambda: obsoleteinfo(repo, hgcmd))),
('hg config (all)', _failsafe(lambda: hgcmd(commands.config))), ('hg config (all)', _failsafe(lambda: hgcmd(commands.config))),
] ]
if util.safehasattr(repo, 'name'):
# Add the contents of both local and shared pack directories.
packlocs = {
'local': lambda category: shallowutil.getlocalpackpath(
repo.svfs.vfs.base, category),
'shared': lambda category: shallowutil.getcachepackpath(repo,
category),
}
for loc, getpath in packlocs.iteritems():
for category in constants.ALL_CATEGORIES:
path = getpath(category)
detailed.append((
"%s packs (%s)" % (loc, constants.getunits(category)),
"%s:\n%s" %
(path, _failsafe(lambda: shcmd("ls -lh %s" % path)))
))
# This is quite slow, so we don't want to do it by default # This is quite slow, so we don't want to do it by default
if ui.configbool("rage", "fastmanifestcached", False): if ui.configbool("rage", "fastmanifestcached", False):
detailed.append( detailed.append(
('hg sl -r "fastmanifestcached()"', ('hg sl -r "fastmanifestcached()"',
_failsafe(lambda: hgcmd(smartlog.smartlog, _failsafe(lambda: hgcmd(smartlog.smartlog,
rev=["fastmanifestcached()"]))), rev=["fastmanifestcached()"]))),
) )

remotefilelog/constants.py

NODECOUNTSIZE = struct.calcsize(NODECOUNTSTRUCT) NODECOUNTSIZE = struct.calcsize(NODECOUNTSTRUCT)
PATHCOUNTSTRUCT = '!I' PATHCOUNTSTRUCT = '!I'
PATHCOUNTSIZE = struct.calcsize(PATHCOUNTSTRUCT) PATHCOUNTSIZE = struct.calcsize(PATHCOUNTSTRUCT)
FILEPACK_CATEGORY="" FILEPACK_CATEGORY=""
TREEPACK_CATEGORY="manifests" TREEPACK_CATEGORY="manifests"
ALL_CATEGORIES = [FILEPACK_CATEGORY, TREEPACK_CATEGORY]
# revision metadata keys. must be a single character. # revision metadata keys. must be a single character.
METAKEYFLAG = 'f' # revlog flag METAKEYFLAG = 'f' # revlog flag
METAKEYSIZE = 's' # full rawtext size METAKEYSIZE = 's' # full rawtext size
def getunits(category): def getunits(category):
if category == FILEPACK_CATEGORY: if category == FILEPACK_CATEGORY:
return _("files") return _("files")
if category == TREEPACK_CATEGORY: if category == TREEPACK_CATEGORY:
return _("trees") return _("trees")