This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12621

check-py3-compat: use an absolute path in sys.path
ClosedPublic

Authored by av6 on Tue, May 10, 3:28 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG3f9125db466f: check-py3-compat: use an absolute path in sys.path
Summary

The idea and rationale is similar to https://phab.mercurial-scm.org/D12599
(landed as 1b6e381521c5).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

av6 created this revision.Tue, May 10, 3:28 AM
Alphare accepted this revision.Tue, May 24, 8:44 AM
This revision is now accepted and ready to land.Tue, May 24, 8:44 AM
Alphare added a comment.Tue, May 24, 8:45 AM

Same as for D12599, this will be queued for stable

baymax updated this revision to Diff 33443.Tue, May 24, 11:45 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)
⚠ This patch is intended for stable ⚠

This revision is now accepted and ready to land.Tue, May 24, 11:45 AM
av6 added a commit: rHG3f9125db466f: check-py3-compat: use an absolute path in sys.path.Tue, May 24, 12:26 PM
Closed by commit rHG3f9125db466f: check-py3-compat: use an absolute path in sys.path (authored by av6). · Explain Why
This revision was automatically updated to reflect the committed changes.
baymax updated this revision to Diff 33448.Tue, May 24, 12:50 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)
⚠ This patch is intended for stable ⚠

Revision Contents
Changeset List

PathPackages
Mcontrib/check-py3-compat.py (2 lines)

Diff 33445

contrib/check-py3-compat.py

# check_compat_py3 will import every filename we specify as long as it # check_compat_py3 will import every filename we specify as long as it
# starts with one of a few prefixes. It does this by converting # starts with one of a few prefixes. It does this by converting
# specified filenames like 'mercurial/foo.py' to 'mercurial.foo' and # specified filenames like 'mercurial/foo.py' to 'mercurial.foo' and
# importing that. When running standalone (not as part of a test), this # importing that. When running standalone (not as part of a test), this
# means we actually import the installed versions, not the files we just # means we actually import the installed versions, not the files we just
# specified. When running as test-check-py3-compat.t, we technically # specified. When running as test-check-py3-compat.t, we technically
# would import the correct paths, but it's cleaner to have both cases # would import the correct paths, but it's cleaner to have both cases
# use the same import logic. # use the same import logic.
sys.path.insert(0, '.') sys.path.insert(0, os.getcwd())
fn = check_compat_py3 fn = check_compat_py3
for f in sys.argv[1:]: for f in sys.argv[1:]:
with warnings.catch_warnings(record=True) as warns: with warnings.catch_warnings(record=True) as warns:
fn(f) fn(f)
for w in warns: for w in warns:
print( print(
warnings.formatwarning( warnings.formatwarning(
w.message, w.category, w.filename, w.lineno w.message, w.category, w.filename, w.lineno
).rstrip() ).rstrip()
) )
sys.exit(0) sys.exit(0)