This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1282

test-dispatch: stabilize the test
ClosedPublic

Authored by quark on Nov 1 2017, 5:25 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG0ccb43d4cf01: test-dispatch: stabilize the test
Summary

When cwd is removed and hg is executed, some shells may run getcwd
before forking and executing, some may not do it, some may print a
different error message.

The test should be shell-independent so let's just avoid checking the error
message.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Nov 1 2017, 5:25 PM
durin42 accepted this revision.Nov 1 2017, 5:26 PM
This revision is now accepted and ready to land.Nov 1 2017, 5:26 PM
Closed by commit rHG0ccb43d4cf01: test-dispatch: stabilize the test (authored by quark). · Explain WhyNov 1 2017, 5:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-dispatch.t (12 lines)

Diff 3197

tests/test-dispatch.t

#if rmcwd #if rmcwd
Current directory removed: Current directory removed:
$ mkdir $TESTTMP/repo1 $ mkdir $TESTTMP/repo1
$ cd $TESTTMP/repo1 $ cd $TESTTMP/repo1
$ rm -rf $TESTTMP/repo1 $ rm -rf $TESTTMP/repo1
$ HGDEMANDIMPORT=disable hg version -q
abort: error getting current working directory: * (glob) (no-chg !) The output could be one of the following and something else:
chg: abort: failed to getcwd (errno = *) (glob) (chg !) chg: abort: failed to getcwd (errno = *) (glob)
[255] abort: error getting current working directory: * (glob)
sh: 0: getcwd() failed: No such file or directory
Since the exact behavior depends on the shell, only check it returns non-zero.
$ HGDEMANDIMPORT=disable hg version -q 2>/dev/null || false
[1]
#endif #endif