This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1368

prefetch: add option to specify base revision
ClosedPublic

Authored by singhsrb on Nov 10 2017, 5:42 PM.
Tags
None
Subscribers
durham

Details

Reviewers
durham
Group Reviewers
Restricted Project
Commits
rFBHGX7e8247381847: prefetch: add option to specify base revision
Summary

Adding the option to specify the base revision in the prefetch
command. This can useful to limit the prefetch data and also makes the
interface of prefetch consistent with prefetchtrees. Soon, we will merge
prefetch and prefetchtrees into a single command and both commands having a
similar interface is useful for the merging.

Test Plan

Ran all the tests.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

singhsrb created this revision.Nov 10 2017, 5:42 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2017, 5:42 PM
durham accepted this revision.Nov 14 2017, 7:16 PM
durham added a subscriber: durham.
durham added inline comments.
tests/test-remotefilelog-prefetch.t
40

It might be better to clear the cache (clearcache) then run this command. That will guarantee that it only downloaded the 2 files from commit #1 because you told it to, and not because they were already in the cache. Then we would see downloads while cat'ing 0 x and 0 z.

This revision is now accepted and ready to land.Nov 14 2017, 7:16 PM
singhsrb added inline comments.Nov 15 2017, 1:59 PM
tests/test-remotefilelog-prefetch.t
40

Makes sense. I will do that!

singhsrb updated this revision to Diff 3532.Nov 15 2017, 1:59 PM
Closed by commit rFBHGX7e8247381847: prefetch: add option to specify base revision (authored by singhsrb). · Explain WhyNov 20 2017, 9:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 3634

remotefilelog/__init__.py

@command('debugwaitonprefetch', [ @command('debugwaitonprefetch', [
], _('hg debugwaitonprefetch')) ], _('hg debugwaitonprefetch'))
def debugwaitonprefetch(ui, repo, **opts): def debugwaitonprefetch(ui, repo, **opts):
return debugcommands.debugwaitonprefetch(repo) return debugcommands.debugwaitonprefetch(repo)
@command('prefetch', [ @command('prefetch', [
('r', 'rev', [], _('prefetch the specified revisions'), _('REV')), ('r', 'rev', [], _('prefetch the specified revisions'), _('REV')),
('', 'repack', False, _('run repack after prefetch')), ('', 'repack', False, _('run repack after prefetch')),
('b', 'base', '', _("rev that is assumed to already be local")),
] + commands.walkopts, _('hg prefetch [OPTIONS] [FILE...]')) ] + commands.walkopts, _('hg prefetch [OPTIONS] [FILE...]'))
def prefetch(ui, repo, *pats, **opts): def prefetch(ui, repo, *pats, **opts):
"""prefetch file revisions from the server """prefetch file revisions from the server
Prefetchs file revisions for the specified revs and stores them in the Prefetchs file revisions for the specified revs and stores them in the
local remotefilelog cache. If no rev is specified, the default rev is local remotefilelog cache. If no rev is specified, the default rev is
used which is the union of dot, draft, pullprefetch and bgprefetchrev. used which is the union of dot, draft, pullprefetch and bgprefetchrev.
File names or patterns can be used to limit which files are downloaded. File names or patterns can be used to limit which files are downloaded.
# update a revset with a date limit # update a revset with a date limit
revset = revdatelimit(ui, revset) revset = revdatelimit(ui, revset)
opts['rev'] = [revset] opts['rev'] = [revset]
revs = scmutil.revrange(repo, opts.get('rev')) revs = scmutil.revrange(repo, opts.get('rev'))
repo.prefetch(revs, pats=pats, opts=opts) base = opts.get('base')
if not base:
base = None
repo.prefetch(revs, base, pats, opts)
# Run repack in background # Run repack in background
if opts.get('repack'): if opts.get('repack'):
repackmod.backgroundrepack(repo, incremental=True) repackmod.backgroundrepack(repo, incremental=True)
@command('repack', [ @command('repack', [
('', 'background', None, _('run in a background process'), None), ('', 'background', None, _('run in a background process'), None),
('', 'incremental', None, _('do an incremental repack'), None), ('', 'incremental', None, _('do an incremental repack'), None),

tests/test-remotefilelog-prefetch.t

$ cd shallow $ cd shallow
$ hg prefetch -r 0 $ hg prefetch -r 0
2 files fetched over 1 fetches - (2 misses, 0.00% hit ratio) over *s (glob) 2 files fetched over 1 fetches - (2 misses, 0.00% hit ratio) over *s (glob)
$ hg cat -r 0 x $ hg cat -r 0 x
x x
# prefetch with base
$ clearcache
durhamUnsubmitted
Not Done

It might be better to clear the cache (clearcache) then run this command. That will guarantee that it only downloaded the 2 files from commit #1 because you told it to, and not because they were already in the cache. Then we would see downloads while cat'ing 0 x and 0 z.

durham: It might be better to clear the cache (`clearcache`) then run this command. That will…
singhsrbAuthorUnsubmitted
Not Done

Makes sense. I will do that!

singhsrb: Makes sense. I will do that!
$ hg prefetch -r 0::1 -b 0
2 files fetched over 1 fetches - (2 misses, 0.00% hit ratio) over *s (glob)
$ hg cat -r 1 x
x2
$ hg cat -r 1 y
y
$ hg cat -r 0 x
x
1 files fetched over 1 fetches - (1 misses, 0.00% hit ratio) over *s (glob)
$ hg cat -r 0 z
z
1 files fetched over 1 fetches - (1 misses, 0.00% hit ratio) over *s (glob)
$ hg prefetch -r 0::1 --base 0
$ hg prefetch -r 0::1 -b 1
$ hg prefetch -r 0::1
# prefetch a range of revisions # prefetch a range of revisions
$ clearcache $ clearcache
$ hg prefetch -r 0::1 $ hg prefetch -r 0::1
4 files fetched over 1 fetches - (4 misses, 0.00% hit ratio) over *s (glob) 4 files fetched over 1 fetches - (4 misses, 0.00% hit ratio) over *s (glob)
$ hg cat -r 0 x $ hg cat -r 0 x
x x