This is an archive of the discontinued Mercurial Phabricator instance.

		Path
M		hgext3rd/checkmessagehook.py (17 lines)
A	M	tests/ctrlchar-msg.txt (8 lines)
A	M	tests/perfectlyok-msg.txt (1 line)
A	M	tests/test-checkmessagehook.t (28 lines)

Diff 3503

	hg_commit_message = repo['tip'].description()			hg_commit_message = repo['tip'].description()
	try:			try:
	hg_commit_message.decode('utf8')			hg_commit_message.decode('utf8')
	except UnicodeDecodeError:			except UnicodeDecodeError:
	ui.warn(_('commit message is not utf-8\n'))			ui.warn(_('commit message is not utf-8\n'))
	return True			return True

	printable = set(string.printable)			printable = set(string.printable)
	for c in hg_commit_message:			badlines = []
				for lnum, line in enumerate(hg_commit_message.splitlines()):
				jsgfAuthorUnsubmitted Done Is this portable? If not, what is? jsgf: Is this portable? If not, what is?
				for c in line:
	if ord(c) < 128 and c not in printable:			if ord(c) < 128 and c not in printable:
				badlines.append((lnum + 1, line))
				break

				if badlines:
	ui.warn(_('non-printable characters in commit message\n'))			ui.warn(_('non-printable characters in commit message\n'))
	return True			for num, l in badlines:
				ui.warn(_('Line {}: {!r}\n'.format(num, l)))

	# False means success			# False means success
	return False			return bool(badlines)

				This is a commit with bad chars in the message - but this one is OK

				That was a blank line

				This has a sneaky ctrl-A: ␁
				And this has esc: ␛

				Finish off with an OK line

This commit message is perfectly OK, and has no sneaky control characters.

				$ cat >> $HGRCPATH <<EOF
				> [extensions]
				> checkmessagehook = $TESTDIR/../hgext3rd/checkmessagehook.py
				> EOF

				Build up a repo

				$ hg init repo
				$ cd repo
				$ touch a
				$ hg commit -A -l $TESTDIR/ctrlchar-msg.txt
				adding a
				non-printable characters in commit message
				Line 5: 'This has a sneaky ctrl-A: \x01'
				Line 6: 'And this has esc: \x1b'
				transaction abort!
				rollback completed
				abort: pretxncommit.checkmessage hook failed
				[255]
				$ hg commit -A -l $TESTDIR/perfectlyok-msg.txt
				durhamUnsubmitted Done Maybe also test that a normal commit can go through. durham: Maybe also test that a normal commit can go through.
				adding a
				$ hg log -r .
				changeset: 0:d9cf9881be7b
				tag: tip
				user: test
				date: Thu Jan 01 00:00:00 1970 +0000
				summary: This commit message is perfectly OK, and has no sneaky control characters.