Instead of wrapping changectx constructor, there is a cleaner way to change
the hidden error message. changectx is constructed frequently so this change
also has perf benefit. It saves about 5ms when running sl on fbsource and
it also makes traceprof able to expand changectx.init call graph.
Details
Details
- Reviewers
durham - Group Reviewers
Restricted Project - Commits
- rFBHGX9a498ad2c6b2: hiddenerror: do not wrap changectx
Diff Detail
Diff Detail
- Repository
- rFBHGX Facebook Mercurial Extensions
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
I assume the tests cover this code path?
hgext3rd/hiddenerror.py | ||
---|---|---|
46 | Is 'rev' guaranteed to be a integer? |
hgext3rd/hiddenerror.py | ||
---|---|---|
46 | Good question. Not sure. Will add a test. |
Is 'rev' guaranteed to be a integer?