This is an archive of the discontinued Mercurial Phabricator instance.

clindex: add prebuilt cython file
ClosedPublic

Authored by mbthomas on Nov 24 2017, 5:19 AM.
Tags
None
Subscribers

Details

Reviewers
swhitaker
quark
Group Reviewers
Restricted Project
Commits
rFBHGX44f3b98943ba: clindex: add prebuilt cython file
Summary

The build currently fails on systems without Cython. Add a prebuilt cython
file for clindex to allow builds on those systems.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mbthomas created this revision.Nov 24 2017, 5:19 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2017, 5:19 AM
swhitaker accepted this revision.Nov 24 2017, 5:20 AM
This revision is now accepted and ready to land.Nov 24 2017, 5:20 AM
quark requested changes to this revision.Nov 24 2017, 1:44 PM
quark added a subscriber: quark.

Unlike linelog and other Cython files which are relatively stable and rarely need change. clindex will be touched frequently, this will hide the issue where clindex.c is left behind.

If you run source hg-dev from fb-hg-rpms and then make local from fb-hgext with cython installed, will it work?

This revision now requires changes to proceed.Nov 24 2017, 1:44 PM
quark added a comment.Nov 24 2017, 1:55 PM

If you want to debug a non-dev version of rusttreedirstate, you can add the following lines in .hgdevrc:

[extensions]
treedirstate = ~/fb-hgext/...

And use relative import in .py to import the Rust module:

from . import ...
from .rust import ...
This revision was automatically updated to reflect the committed changes.