Page MenuHomePhabricator

remotefilelog: error gracefuly when the file is too big
AbandonedPublic

Authored by mitrandir on Nov 24 2017, 12:05 PM.

Details

Reviewers
mbthomas
Group Reviewers
Restricted Project
Summary

We don't really support files larger than 2G with files larger than
4G remotefilelog crashes badly.

Test Plan

Tested with 4G file, doens't crash now. No tests as test would involve
creating such a large file.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mitrandir created this revision.Nov 24 2017, 12:05 PM
Herald added a reviewer: Restricted Project. ยท View Herald TranscriptNov 24 2017, 12:05 PM

Can you test the logic by monkeypatching _maxentrysize to a smaller number?

mbthomas requested changes to this revision.Nov 24 2017, 12:25 PM
This revision now requires changes to proceed.Nov 24 2017, 12:25 PM
durham added a subscriber: durham.Nov 28 2017, 11:13 AM
durham added inline comments.
remotefilelog/remotefilelog.py
129

I think there's a util.bytecount() function that can turn a number of bytes into a human readable string (like 2.1GB)

mitrandir abandoned this revision.Feb 23 2018, 10:58 AM