Page MenuHomePhabricator

infinitepush: be compatible with upstream change
ClosedPublic

Authored by quark on Dec 1 2017, 4:18 PM.

Details

Reviewers
durham
singhsrb
Group Reviewers
Restricted Project
Commits
rFBHGXe3c118224daf: infinitepush: be compatible with upstream change
Summary

The upstream has made the bundle parts non-seekable to reduce memory usage.
So we need to copy a bundle part if we need to process it later.

Also, fix an apparent issue where part should be scratchbookpart.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Dec 1 2017, 4:18 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2017, 4:18 PM
durham accepted this revision.Dec 1 2017, 4:22 PM
durham added a subscriber: durham.
durham added inline comments.
infinitepush/__init__.py
1093

I wonder if we could use your copy function here too. This code (below) copies the parameters individually, which might be safer than reusing the dictionaries.

No need to do so now. Just an observation at a common copy pattern.

This revision is now accepted and ready to land.Dec 1 2017, 4:22 PM
singhsrb accepted this revision.Dec 1 2017, 4:28 PM
singhsrb added a subscriber: singhsrb.
singhsrb added inline comments.
infinitepush/__init__.py
1136

Nice!

This revision was automatically updated to reflect the committed changes.