This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1595

test-run-tests: do not rebuild hg in the test
ClosedPublic

Authored by quark on Dec 5 2017, 3:27 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG2a99c5bfea47: test-run-tests: do not rebuild hg in the test
Summary

d600bda4 and fc0f3ed0 added code to call $PYTHON run-tests.py .... That
will rebuild hg, is slow and could have other crashes from setup.py, like:

Unable to find a working hg binary to extract the version from the
repository tags

Therefore use run-tests.py -l instead.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Dec 5 2017, 3:27 PM
durin42 accepted this revision.Dec 5 2017, 5:18 PM
This revision is now accepted and ready to land.Dec 5 2017, 5:18 PM
Closed by commit rHG2a99c5bfea47: test-run-tests: do not rebuild hg in the test (authored by quark). · Explain WhyDec 5 2017, 5:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-run-tests.t (4 lines)

Diff 4143

tests/test-run-tests.t

> line > line
> EOF > EOF
$ cp test-uno.t test-dos.t $ cp test-uno.t test-dos.t
$ cd .. $ cd ..
$ cp -R tmp tmpp $ cp -R tmp tmpp
$ cp tmp/test-uno.t test-solo.t $ cp tmp/test-uno.t test-solo.t
$ $PYTHON $TESTDIR/run-tests.py tmp/ test-solo.t tmpp $ rt tmp/ test-solo.t tmpp
..... .....
# Ran 5 tests, 0 skipped, 0 failed. # Ran 5 tests, 0 skipped, 0 failed.
$ rm -rf tmp tmpp $ rm -rf tmp tmpp
support for running run-tests.py from another directory support for running run-tests.py from another directory
$ mkdir tmp && cd tmp $ mkdir tmp && cd tmp
$ cat > useful-file.sh << EOF $ cat > useful-file.sh << EOF
> important command > important command
> EOF > EOF
$ cat > test-folder.t << EOF $ cat > test-folder.t << EOF
> $ cat \$TESTDIR/useful-file.sh > $ cat \$TESTDIR/useful-file.sh
> important command > important command
> EOF > EOF
$ cat > test-folder-fail.t << EOF $ cat > test-folder-fail.t << EOF
> $ cat \$TESTDIR/useful-file.sh > $ cat \$TESTDIR/useful-file.sh
> important commando > important commando
> EOF > EOF
$ cd .. $ cd ..
$ $PYTHON $TESTDIR/run-tests.py tmp/test-*.t $ rt tmp/test-*.t
--- $TESTTMP/anothertests/tmp/test-folder-fail.t --- $TESTTMP/anothertests/tmp/test-folder-fail.t
+++ $TESTTMP/anothertests/tmp/test-folder-fail.t.err +++ $TESTTMP/anothertests/tmp/test-folder-fail.t.err
@@ -1,2 +1,2 @@ @@ -1,2 +1,2 @@
$ cat $TESTDIR/useful-file.sh $ cat $TESTDIR/useful-file.sh
- important commando - important commando
+ important command + important command