This is an archive of the discontinued Mercurial Phabricator instance.

fsmonitor: remove watchman transaction and working copy change notifications
ClosedPublic

Authored by ekent on Dec 6 2017, 9:54 PM.

Details

Summary

Remove working copy change and transaction notifications. We were relying
upon callbacks on transaction function. This caused issues with lock ordering.
A different approach will be adopted in a subsequent commit.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ekent created this revision.Dec 6 2017, 9:54 PM
durin42 added a subscriber: durin42.Dec 7 2017, 2:19 PM

Are the commit messages on this and D1612 swapped somehow?

ekent retitled this revision from fsmonitor: fsmonitor should send wlock notifications to watchman to fsmonitor: remove watchman transaction and working copy change notifications.Dec 7 2017, 7:37 PM
ekent edited the summary of this revision. (Show Details)
durin42 accepted this revision.Dec 8 2017, 2:32 PM
This revision is now accepted and ready to land.Dec 8 2017, 2:32 PM
This revision was automatically updated to reflect the committed changes.