When fully uncommitting a commit on top of a public commit, uncommit
erroneously marks the new current commit with the same phase as the old
commit. It should only do that in the case of a partial commit,
where the new current commit is a new commit.
Details
Details
- Reviewers
ryanmce - Group Reviewers
Restricted Project - Commits
- rFBHGXf6510b66b72e: uncommit: keep parent phase for full uncommit
Add tests to test-uncommit.t.
Diff Detail
Diff Detail
- Repository
- rFBHGX Facebook Mercurial Extensions
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
I think you can make this change more surgical by just checking the hash at the caller.
hgext3rd/uncommit.py | ||
---|---|---|
164–170 | Rather than passing back an additional parameter , can't we check if the newid is old.parent's hash? Then this change will be less invasive. |
Rather than passing back an additional parameter , can't we check if the newid is old.parent's hash? Then this change will be less invasive.