This is an archive of the discontinued Mercurial Phabricator instance.

tests: add commit hashes to log commands in rebase tests
ClosedPublic

Authored by phillco on Dec 11 2017, 12:57 AM.

Details

Summary

Commit hashes are a useful way to ensure the content of commits made in the
tests are not changing, even if we don't query every aspect of every commit.
(And some properties, like extras, are rarely printed at all.)

Many of the rebase log -G calls didn't show hashes; by adding hashes to places
that weren't showing them we can help protect those tests from unwanted
changes.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

phillco created this revision.Dec 11 2017, 12:57 AM

(To make this easier to review, I sent D1651 as an abandoned diff that just makes the changes to the log -G calls. You could take that one, then run the whole test suite and accept the changes, if it'd be easier to review.)

durin42 accepted this revision.Dec 11 2017, 11:26 AM
This revision is now accepted and ready to land.Dec 11 2017, 11:26 AM
This revision was automatically updated to reflect the committed changes.