Page MenuHomePhabricator

perftweaks: pass a correct revgen to branchcache.update
AbandonedPublic

Authored by quark on Dec 11 2017, 7:39 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

The revgen parameter cannot be null. Otherwise the "for i in None" code path
will be executed if disablebranchcache is False while disablebranchcache2 is
True.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Dec 11 2017, 7:39 PM
Herald added a reviewer: Restricted Project. ยท View Herald TranscriptDec 11 2017, 7:39 PM
quark abandoned this revision.Dec 7 2019, 2:12 AM

No longer needed.