This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1665

perftweaks: pass a correct revgen to branchcache.update
AbandonedPublic

Authored by quark on Dec 11 2017, 7:39 PM.
Tags
None
Subscribers
None

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

The revgen parameter cannot be null. Otherwise the "for i in None" code path
will be executed if disablebranchcache is False while disablebranchcache2 is
True.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Dec 11 2017, 7:39 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 11 2017, 7:39 PM
quark abandoned this revision.Dec 7 2019, 2:12 AM

No longer needed.

Revision Contents
Changeset List

PathPackages
Mhgext3rd/perftweaks.py (2 lines)

Diff 4373

hgext3rd/perftweaks.py

# The original logic has unnecessary steps, ex. it calculates the "served" # The original logic has unnecessary steps, ex. it calculates the "served"
# repoview as an attempt to build branchcache for "visible". And then # repoview as an attempt to build branchcache for "visible". And then
# calculates "immutable" for calculating "served", recursively. # calculates "immutable" for calculating "served", recursively.
# #
# Just use a shortcut path that construct the branchcache directly. # Just use a shortcut path that construct the branchcache directly.
partial = repo._branchcaches.get(repo.filtername) partial = repo._branchcaches.get(repo.filtername)
if partial is None: if partial is None:
partial = branchmap.branchcache() partial = branchmap.branchcache()
partial.update(repo, None) partial.update(repo, [])
repo._branchcaches[repo.filtername] = partial repo._branchcaches[repo.filtername] = partial
# _docommit accesses "branchheads" just to decide whether to show "(created new # _docommit accesses "branchheads" just to decide whether to show "(created new
# head)" or not. Accessing branchheads requires calling "headrevs()" which is # head)" or not. Accessing branchheads requires calling "headrevs()" which is
# expensive since it scans entire changelog. We don't use named branches and # expensive since it scans entire changelog. We don't use named branches and
# do not worry about multiple heads. # do not worry about multiple heads.
def _docommit(orig, ui, repo, *pats, **opts): def _docommit(orig, ui, repo, *pats, **opts):
# developer config: perftweaks.disableheaddetection # developer config: perftweaks.disableheaddetection