This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1676

revset: take out logic generating matcher for empty spec in it's own fn
AbandonedPublic

Authored by pulkit on Dec 12 2017, 8:54 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

This will help us in calling the functions from another modules and is done so
that we can get the tree object parsed at revset.matchany() and update
visibility exceptions based on that.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/revset.py (8 lines)

Diff 4412

mercurial/revset.py

def posttreebuilthook(tree, repo): def posttreebuilthook(tree, repo):
# hook for extensions to execute code on the optimized tree # hook for extensions to execute code on the optimized tree
pass pass
def match(ui, spec, repo=None): def match(ui, spec, repo=None):
"""Create a matcher for a single revision spec""" """Create a matcher for a single revision spec"""
return matchany(ui, [spec], repo=repo) return matchany(ui, [spec], repo=repo)
def emptymatcher(repo, subset=None):
""" Matcher for empty specs """
return baseset()
def matchany(ui, specs, repo=None, localalias=None): def matchany(ui, specs, repo=None, localalias=None):
"""Create a matcher that will include any revisions matching one of the """Create a matcher that will include any revisions matching one of the
given specs given specs
If localalias is not None, it is a dict {name: definitionstring}. It takes If localalias is not None, it is a dict {name: definitionstring}. It takes
precedence over [revsetalias] config section. precedence over [revsetalias] config section.
""" """
if not specs: if not specs:
def mfunc(repo, subset=None): return emptymatcher
return baseset()
return mfunc
if not all(specs): if not all(specs):
raise error.ParseError(_("empty query")) raise error.ParseError(_("empty query"))
lookup = None lookup = None
if repo: if repo:
lookup = repo.__contains__ lookup = repo.__contains__
if len(specs) == 1: if len(specs) == 1:
tree = revsetlang.parse(specs[0], lookup) tree = revsetlang.parse(specs[0], lookup)
else: else: