This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1715

completion: don't suggest clean files to revert
ClosedPublic

Authored by martinvonz on Dec 18 2017, 2:25 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHGfdbe4eafa9c2: completion: don't suggest clean files to revert
Summary

It looks like we used to suggest only modified, added, removed and
deleted files to revert until a821ec835223 (completion: selectively
use debugpathcomplete in bash_completion, 2013-03-21). The reasoning
in that commit was that getting the status was too slow and the
replacement (debugpathcomplete) seems to make sense for the other two
commands (remove and forget), but I'm not sure it was intentional to
change the behavior of completion for revert. Note that "add" and
"diff" already use status-based completion.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Dec 18 2017, 2:25 PM
yuja accepted this revision.Dec 20 2017, 8:11 AM
This revision is now accepted and ready to land.Dec 20 2017, 8:11 AM
Closed by commit rHGfdbe4eafa9c2: completion: don't suggest clean files to revert (authored by martinvonz). · Explain WhyDec 20 2017, 8:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/bash_completion (2 lines)

Diff 4559

contrib/bash_completion

;; ;;
forget) forget)
_hg_debugpathcomplete -fa _hg_debugpathcomplete -fa
;; ;;
diff) diff)
_hg_status "mar" _hg_status "mar"
;; ;;
revert) revert)
_hg_debugpathcomplete _hg_status "mard"
;; ;;
clone) clone)
local count=$(_hg_count_non_option) local count=$(_hg_count_non_option)
if [ $count = 1 ]; then if [ $count = 1 ]; then
_hg_paths _hg_paths
fi fi
_hg_repos _hg_repos
;; ;;