( )⚙ D1740 journal: use pager

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1740

journal: use pager
ClosedPublic

Authored by quark on Dec 20 2017, 7:45 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG6f754b0fe54e: journal: use pager
Summary

journal output is long and should use a pager.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Dec 20 2017, 7:45 PM
durin42 accepted this revision.Dec 20 2017, 8:33 PM
This revision is now accepted and ready to land.Dec 20 2017, 8:33 PM
Closed by commit rHG6f754b0fe54e: journal: use pager (authored by quark). · Explain WhyDec 21 2017, 1:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/journal.py (1 line)

Diff 4571

hgext/journal.py

if name is None: if name is None:
displayname = _('the working copy and bookmarks') displayname = _('the working copy and bookmarks')
else: else:
displayname = "'%s'" % name displayname = "'%s'" % name
ui.status(_("previous locations of %s:\n") % displayname) ui.status(_("previous locations of %s:\n") % displayname)
limit = cmdutil.loglimit(opts) limit = cmdutil.loglimit(opts)
entry = None entry = None
ui.pager('journal')
for count, entry in enumerate(repo.journal.filtered(name=name)): for count, entry in enumerate(repo.journal.filtered(name=name)):
if count == limit: if count == limit:
break break
newhashesstr = fm.formatlist(map(fm.hexfunc, entry.newhashes), newhashesstr = fm.formatlist(map(fm.hexfunc, entry.newhashes),
name='node', sep=',') name='node', sep=',')
oldhashesstr = fm.formatlist(map(fm.hexfunc, entry.oldhashes), oldhashesstr = fm.formatlist(map(fm.hexfunc, entry.oldhashes),
name='node', sep=',') name='node', sep=',')