( )⚙ D1742 p4fastimport: return the last changelist number that affects the client view

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1742

p4fastimport: return the last changelist number that affects the client view
AcceptedPublic

Authored by dsp on Dec 21 2017, 8:18 PM.
Tags
None
Subscribers
None

Details

Reviewers
quark
Summary

Previously we returned the last changelist number of any change a
client can see. This includes changes outside of the files specified in the
view. We now return the last changelist number of files affected by the client
view.

Test Plan

python ../../hg-crew/tests/run-tests.py test-check* test-p4fastimport*

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark accepted this revision.Dec 21 2017, 10:26 PM
This revision is now accepted and ready to land.Dec 21 2017, 10:26 PM

Revision Contents
Changeset List

Diff 4576

hgext3rd/p4fastimport/p4.py

@retry(num=5, sleeps=0.3) @retry(num=5, sleeps=0.3)
def helper(): def helper():
stdout = util.popen(cmd, mode='rb') stdout = util.popen(cmd, mode='rb')
content = stdout.read() content = stdout.read()
return content return content
return helper() return helper()
def get_latest_cl(client): def get_latest_cl(client):
cmd = 'p4 --client %s -G changes -m 1 -s submitted' % ( cmd = 'p4 --client %s -G changes -m 1 -s submitted //%s/...' % (
util.shellquote(client),
util.shellquote(client)) util.shellquote(client))
stdout = util.popen(cmd, mode='rb') stdout = util.popen(cmd, mode='rb')
parsed = marshal.load(stdout) parsed = marshal.load(stdout)
cl = parsed.get('change') cl = parsed.get('change')
if cl: if cl:
return int(cl) return int(cl)
return None return None