This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1752

tests: show phases aren't preserved part of streaming clone (issue5648)
Needs RevisionPublic

Authored by indygreg on Dec 24 2017, 1:06 PM.

Details

Reviewers
baymax
Group Reviewers
hg-reviewers
Summary

draft and secret changesets are promoted to public changesets when
transferred via a stream clone. That's not desirable behavior. Add
tests demonstrating it.

As far as I can tell, this buggy behavior has been present since
phases were introduced. Stream clone predated phases (1.7 versus 1.9)
and stream clone was never taught to be phase aware.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Dec 24 2017, 1:06 PM
baymax requested changes to this revision.Jan 24 2020, 12:33 PM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Jan 24 2020, 12:33 PM

Revision Contents
Changeset List

PathPackages
Mtests/test-clone-uncompressed.t (65 lines)

Diff 4602

tests/test-clone-uncompressed.t

sending getbundle command sending getbundle command
bundle2-input-bundle: with-transaction bundle2-input-bundle: with-transaction
bundle2-input-part: "listkeys" (params: 1 mandatory) supported bundle2-input-part: "listkeys" (params: 1 mandatory) supported
bundle2-input-part: "phase-heads" supported bundle2-input-part: "phase-heads" supported
bundle2-input-part: total payload size 24 bundle2-input-part: total payload size 24
bundle2-input-bundle: 1 parts total bundle2-input-bundle: 1 parts total
checking for updated bookmarks checking for updated bookmarks
Phases on publishing server are promoted to public
$ hg -R server log -T '{rev} {phase}\n'
1 draft
0 draft
$ hg clone --stream -U http://localhost:$HGPORT publishing-server
streaming all changes
1027 files to transfer, 96.3 KB of data
transferred 96.3 KB in * seconds (*/sec) (glob)
searching for changes
no changes found
$ hg -R publishing-server log -T '{rev} {phase}\n'
1 public
0 public
Phases on non-publishing server are preserved as draft
$ killdaemons.py
$ cd server
$ cat >> .hg/hgrc << EOF
> [phases]
> publish = false
> EOF
$ hg serve -p $HGPORT -d --pid-file=hg.pid
$ cat hg.pid > $DAEMON_PIDS
$ cd ..
$ hg clone --stream -U http://localhost:$HGPORT all-draft
streaming all changes
1027 files to transfer, 96.3 KB of data
transferred 96.3 KB in * seconds (*/sec) (glob)
searching for changes
no changes found
TODO this is buggy
$ hg -R all-draft log -T '{rev} {phase}\n'
1 public
0 public
Mixed phase is preserved
$ hg -R server phase --public -r 0
$ hg clone --stream -U http://localhost:$HGPORT mixed-draft
streaming all changes
1027 files to transfer, 96.3 KB of data
transferred 96.3 KB in * seconds (*/sec) (glob)
searching for changes
no changes found
TODO this is buggy
$ hg -R mixed-draft log -T '{rev} {phase}\n'
1 public
0 public
Cannot stream clone when there are secret changesets Cannot stream clone when there are secret changesets
$ hg -R server phase --force --secret -r tip $ hg -R server phase --force --secret -r tip
$ hg clone --stream -U http://localhost:$HGPORT secret-denied $ hg clone --stream -U http://localhost:$HGPORT secret-denied
warning: stream clone requested but server has them disabled warning: stream clone requested but server has them disabled
requesting all changes requesting all changes
adding changesets adding changesets
adding manifests adding manifests
$ hg clone --stream -U http://localhost:$HGPORT secret-allowed $ hg clone --stream -U http://localhost:$HGPORT secret-allowed
streaming all changes streaming all changes
1027 files to transfer, 96.3 KB of data 1027 files to transfer, 96.3 KB of data
transferred 96.3 KB in * seconds (*/sec) (glob) transferred 96.3 KB in * seconds (*/sec) (glob)
searching for changes searching for changes
no changes found no changes found
TODO this is buggy
(likely requires bundle2 stream clone support to fix)
$ hg -R secret-allowed log -T '{rev} {phase}\n'
1 public
0 public
$ killdaemons.py $ killdaemons.py
Verify interaction between preferuncompressed and secret presence Verify interaction between preferuncompressed and secret presence
$ cd server $ cd server
$ hg serve --config server.preferuncompressed=true -p $HGPORT -d --pid-file=hg.pid $ hg serve --config server.preferuncompressed=true -p $HGPORT -d --pid-file=hg.pid
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ cd .. $ cd ..