This is an archive of the discontinued Mercurial Phabricator instance.

logexchange: introduce helper function to get remote path name
ClosedPublic

Authored by pulkit on Dec 25 2017, 4:57 AM.

Details

Summary

This patch moves chunk of activepath function from hgremotenames extension
(https://bitbucket.org/seanfarley/hgremotenames/) to core. Before moving
rest of the part, there needs to be some refactoring done to schemes which
will be done as a separate series.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Dec 25 2017, 4:57 AM
pulkit edited the summary of this revision. (Show Details)Dec 25 2017, 5:34 AM
durin42 requested changes to this revision.Jan 10 2018, 6:18 PM
durin42 added a subscriber: durin42.
durin42 added inline comments.
mercurial/logexchange.py
110

This should be cleaned up to not have all the getattr contortions that support old hg versions.

This revision now requires changes to proceed.Jan 10 2018, 6:18 PM
pulkit updated this revision to Diff 4794.Jan 11 2018, 5:33 AM
durin42 added inline comments.Jan 18 2018, 3:02 PM
mercurial/logexchange.py
103

what's the deal with this attributeerror business? merits a comment at least

114

is the attribute name here really still inconsistent in hg?

pulkit updated this revision to Diff 5144.Feb 2 2018, 2:47 AM

I will like to get this series review and iterated upon early in cycle so that we can ship remotenames in the next release.

durin42 accepted this revision.Feb 12 2018, 3:26 PM
This revision is now accepted and ready to land.Feb 12 2018, 3:26 PM
This revision was automatically updated to reflect the committed changes.