This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1809

tests: switch test from '--config ui.editor=~/foo' to HGEDITOR=~/foo
ClosedPublic

Authored by spectral on Jan 4 2018, 7:29 PM.

Details

Reviewers
krbullock
Group Reviewers
hg-reviewers
Commits
rHG711149d8e676: tests: switch test from '--config ui.editor=~/foo' to HGEDITOR=~/foo
Summary

The test is currently not testing anything, the '--config ui.editor=~/path'
argument is apparently of lower priority than the HGEDITOR that run-tests.py is
setting.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Jan 4 2018, 7:29 PM
krbullock accepted this revision.Jan 4 2018, 10:24 PM
krbullock added a subscriber: krbullock.

Queued, thanks

This revision is now accepted and ready to land.Jan 4 2018, 10:24 PM
Closed by commit rHG711149d8e676: tests: switch test from '--config ui.editor=~/foo' to HGEDITOR=~/foo (authored by spectral). · Explain WhyJan 4 2018, 10:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-install.t (4 lines)

Diff 4696

tests/test-install.t

"usernameerror": "no username supplied", "usernameerror": "no username supplied",
path variables are expanded (~ is the same as $TESTTMP) path variables are expanded (~ is the same as $TESTTMP)
$ mkdir tools $ mkdir tools
$ touch tools/testeditor.exe $ touch tools/testeditor.exe
#if execbit #if execbit
$ chmod 755 tools/testeditor.exe $ chmod 755 tools/testeditor.exe
#endif #endif
$ hg debuginstall --config ui.editor=~/tools/testeditor.exe $ HGEDITOR="~/tools/testeditor.exe" hg debuginstall
checking encoding (ascii)... checking encoding (ascii)...
checking Python executable (*) (glob) checking Python executable (*) (glob)
checking Python version (*) (glob) checking Python version (*) (glob)
checking Python lib (*lib*)... (glob) checking Python lib (*lib*)... (glob)
checking Python security support (*) (glob) checking Python security support (*) (glob)
TLS 1.2 not supported by Python install; network connections lack modern security (?) TLS 1.2 not supported by Python install; network connections lack modern security (?)
SNI not supported by Python install; may have connectivity issues with some servers (?) SNI not supported by Python install; may have connectivity issues with some servers (?)
checking Mercurial version (*) (glob) checking Mercurial version (*) (glob)
checking Mercurial custom build (*) (glob) checking Mercurial custom build (*) (glob)
checking module policy (*) (glob) checking module policy (*) (glob)
checking installed modules (*mercurial)... (glob) checking installed modules (*mercurial)... (glob)
checking registered compression engines (*zlib*) (glob) checking registered compression engines (*zlib*) (glob)
checking available compression engines (*zlib*) (glob) checking available compression engines (*zlib*) (glob)
checking available compression engines for wire protocol (*zlib*) (glob) checking available compression engines for wire protocol (*zlib*) (glob)
checking "re2" regexp engine \((available|missing)\) (re) checking "re2" regexp engine \((available|missing)\) (re)
checking templates (*mercurial?templates)... (glob) checking templates (*mercurial?templates)... (glob)
checking default template (*mercurial?templates?map-cmdline.default) (glob) checking default template (*mercurial?templates?map-cmdline.default) (glob)
checking commit editor... (* -c "import sys; sys.exit(0)") (glob) checking commit editor... ($TESTTMP/tools/testeditor.exe)
checking username (test) checking username (test)
no problems detected no problems detected
#if test-repo #if test-repo
$ . "$TESTDIR/helpers-testrepo.sh" $ . "$TESTDIR/helpers-testrepo.sh"
$ cat >> wixxml.py << EOF $ cat >> wixxml.py << EOF
> import os, subprocess, sys > import os, subprocess, sys