This is an archive of the discontinued Mercurial Phabricator instance.

phabricator: convert unicode to binary when writing patches
ClosedPublic

Authored by quark on Jul 27 2017, 3:51 PM.

Reviewers

None

Group Reviewers

hg-reviewers

Commits

Summary

This is a quick fix to make hg phabread D189 work.

It seems we might want to replace all r'' to u'', and add more
encoding.*to* to be more explicit when interacting with json module.

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			contrib/phabricator.py (3 lines)

	# Try to preserve metadata from hg:meta property. Write hg patch			# Try to preserve metadata from hg:meta property. Write hg patch
	# headers that can be read by the "import" command. See patchheadermap			# headers that can be read by the "import" command. See patchheadermap
	# and extract in mercurial/patch.py for supported headers.			# and extract in mercurial/patch.py for supported headers.
	meta = getdiffmeta(diffs[str(diffid)])			meta = getdiffmeta(diffs[str(diffid)])
	for k in _metanamemap.keys():			for k in _metanamemap.keys():
	if k in meta:			if k in meta:
	header += '# %s %s\n' % (_metanamemap[k], meta[k])			header += '# %s %s\n' % (_metanamemap[k], meta[k])

	write(('%s%s\n%s') % (header, desc, body))			content = '%s%s\n%s' % (header, desc, body)
				write(encoding.unitolocal(content))

	@command('phabread',			@command('phabread',
	[('', 'stack', False, _('read dependencies'))],			[('', 'stack', False, _('read dependencies'))],
	_('REVID [OPTIONS]'))			_('REVID [OPTIONS]'))
	def phabread(ui, repo, revid, **opts):			def phabread(ui, repo, revid, **opts):
	"""print patches from Phabricator suitable for importing			"""print patches from Phabricator suitable for importing

	REVID could be a Differential Revision identity, like ``D123``, or just the			REVID could be a Differential Revision identity, like ``D123``, or just the