( )⚙ D192 phabricator: convert unicode to binary when writing patches

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D192

phabricator: convert unicode to binary when writing patches
ClosedPublic

Authored by quark on Jul 27 2017, 3:51 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG850d2ec2cf6a: phabricator: convert unicode to binary when writing patches
Summary

This is a quick fix to make hg phabread D189 work.

It seems we might want to replace all r'' to u'', and add more
encoding.*to* to be more explicit when interacting with json module.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Jul 27 2017, 3:51 PM
Closed by commit rHG850d2ec2cf6a: phabricator: convert unicode to binary when writing patches (authored by quark). · Explain WhyJul 27 2017, 3:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/phabricator.py (3 lines)

Diff 429

contrib/phabricator.py

# Try to preserve metadata from hg:meta property. Write hg patch # Try to preserve metadata from hg:meta property. Write hg patch
# headers that can be read by the "import" command. See patchheadermap # headers that can be read by the "import" command. See patchheadermap
# and extract in mercurial/patch.py for supported headers. # and extract in mercurial/patch.py for supported headers.
meta = getdiffmeta(diffs[str(diffid)]) meta = getdiffmeta(diffs[str(diffid)])
for k in _metanamemap.keys(): for k in _metanamemap.keys():
if k in meta: if k in meta:
header += '# %s %s\n' % (_metanamemap[k], meta[k]) header += '# %s %s\n' % (_metanamemap[k], meta[k])
write(('%s%s\n%s') % (header, desc, body)) content = '%s%s\n%s' % (header, desc, body)
write(encoding.unitolocal(content))
@command('phabread', @command('phabread',
[('', 'stack', False, _('read dependencies'))], [('', 'stack', False, _('read dependencies'))],
_('REVID [OPTIONS]')) _('REVID [OPTIONS]'))
def phabread(ui, repo, revid, **opts): def phabread(ui, repo, revid, **opts):
"""print patches from Phabricator suitable for importing """print patches from Phabricator suitable for importing
REVID could be a Differential Revision identity, like ``D123``, or just the REVID could be a Differential Revision identity, like ``D123``, or just the