This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1959

testrunner: on error, color the "(case xxx)" part the same as filename
ClosedPublic

Authored by martinvonz on Feb 1 2018, 12:18 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG8a7140ec4c89: testrunner: on error, color the "(case xxx)" part the same as filename
rHG81c3ad368574: testrunner: on error, color the "(case xxx)" part the same as filename
Summary

When using #testcases, the lines that read something like

ERROR: test-split.t (case obsstore-off) output changed

get colored red and the filename gets highlighted with a brighter
red. This makes it harder to notice the "case obsstore-off" part, but
it does seem important, so let's highlight it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Feb 1 2018, 12:18 PM
indygreg accepted this revision.Feb 1 2018, 3:43 PM
This revision is now accepted and ready to land.Feb 1 2018, 3:43 PM
Closed by commit rHG81c3ad368574: testrunner: on error, color the "(case xxx)" part the same as filename (authored by martinvonz). · Explain WhyFeb 1 2018, 3:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (5 lines)

Diff 5077

tests/run-tests.py

styles = { styles = {
skipped: '#e5e5e5', skipped: '#e5e5e5',
skippedname: '#00ffff', skippedname: '#00ffff',
failed: '#7f0000', failed: '#7f0000',
failedname: '#ff0000', failedname: '#ff0000',
} }
class TestRunnerLexer(lexer.RegexLexer): class TestRunnerLexer(lexer.RegexLexer):
testpattern = r'[\w-]+\.(t|py)( \(case [\w-]+\))?'
tokens = { tokens = {
'root': [ 'root': [
(r'^Skipped', token.Generic.Skipped, 'skipped'), (r'^Skipped', token.Generic.Skipped, 'skipped'),
(r'^Failed ', token.Generic.Failed, 'failed'), (r'^Failed ', token.Generic.Failed, 'failed'),
(r'^ERROR: ', token.Generic.Failed, 'failed'), (r'^ERROR: ', token.Generic.Failed, 'failed'),
], ],
'skipped': [ 'skipped': [
(r'[\w-]+\.(t|py)', token.Generic.SName), (testpattern, token.Generic.SName),
(r':.*', token.Generic.Skipped), (r':.*', token.Generic.Skipped),
], ],
'failed': [ 'failed': [
(r'[\w-]+\.(t|py)', token.Generic.FName), (testpattern, token.Generic.FName),
(r'(:| ).*', token.Generic.Failed), (r'(:| ).*', token.Generic.Failed),
] ]
} }
runnerformatter = formatters.Terminal256Formatter(style=TestRunnerStyle) runnerformatter = formatters.Terminal256Formatter(style=TestRunnerStyle)
runnerlexer = TestRunnerLexer() runnerlexer = TestRunnerLexer()
if sys.version_info > (3, 5, 0): if sys.version_info > (3, 5, 0):