This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1960

testrunner: make reading of test times work with #testcases
ClosedPublic

Authored by martinvonz on Feb 1 2018, 12:19 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG568917059243: testrunner: make reading of test times work with #testcases
Summary

Due to a bug that will be fixed in the next patch, we never actually
read back .testcases, so we didn't notice that it could not be parsed
successfully when there are #testcases tests. The parsing failed on
lines like "test-amend-subrepo.t (case obsstore-off) 32.420" because
we used a simple string.split() call and expected all parts but the
first to be floating point numbers (and "(case" isn't, for
example). Fix by using a regex instead.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Feb 1 2018, 12:19 PM
martinvonz added a comment.Feb 1 2018, 12:21 PM

I wrote this patch before D1959, but perhaps I should rebase it on top of that and reuse the same regex for matching the test case?

durin42 accepted this revision.Feb 1 2018, 5:36 PM
This revision is now accepted and ready to land.Feb 1 2018, 5:36 PM
Closed by commit rHG568917059243: testrunner: make reading of test times work with #testcases (authored by martinvonz). · Explain WhyFeb 1 2018, 5:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (5 lines)

Diff 5088

tests/run-tests.py

# alphabetically, while times for each test are listed from oldest to # alphabetically, while times for each test are listed from oldest to
# newest. # newest.
def loadtimes(outputdir): def loadtimes(outputdir):
times = [] times = []
try: try:
with open(os.path.join(outputdir, b'.testtimes-')) as fp: with open(os.path.join(outputdir, b'.testtimes-')) as fp:
for line in fp: for line in fp:
ts = line.split() m = re.match('(.*?) ([0-9. ]+)', line)
times.append((ts[0], [float(t) for t in ts[1:]])) times.append((m.group(1),
[float(t) for t in m.group(2).split()]))
except IOError as err: except IOError as err:
if err.errno != errno.ENOENT: if err.errno != errno.ENOENT:
raise raise
return times return times
def savetimes(outputdir, result): def savetimes(outputdir, result):
saved = dict(loadtimes(outputdir)) saved = dict(loadtimes(outputdir))
maxruns = 5 maxruns = 5