Page MenuHomePhabricator

largefiles: register wire protocol commands with modern APIs
ClosedPublic

Authored by indygreg on Feb 2 2018, 8:50 PM.

Details

Summary

The wireproto.wireprotocommand decorator is the preferred mechanism for
registering wire protocol commands. In addition, wireproto.commands
is no longer a 2-tuple and use of that 2-tuple API should be considered
deprecated.

This commit ports largefiles to use wireproto.wireprotocommand()
and ports to the "commandentry" API.

As part of this, the definition of the "lheads" wire protocol
command is moved to the proper stanza.

We stop short of actually using wireprotocommand as a decorator
in order to minimize churn. We should ideally move wire protocol
commands to the registrar mechanism. But that's for another
changeset.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 2 2018, 8:50 PM
durin42 accepted this revision.Feb 7 2018, 5:30 PM
This revision is now accepted and ready to land.Feb 7 2018, 5:30 PM
This revision was automatically updated to reflect the committed changes.