This is an archive of the discontinued Mercurial Phabricator instance.

Differential D218

phabricator: add --confirm option to phabsend command
ClosedPublic

Authored by pulkit on Aug 2 2017, 5:40 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG40cfe3197bc1: phabricator: add --confirm option to phabsend command
Summary

This adds a --confirm flag similar to the confirm flag of hg email using which
one can confirm the changesets before they get emailed. The confirm flag will
show the changesets and ask for confirmation before sending them.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Aug 2 2017, 5:40 PM
pulkit updated this revision to Diff 515.Aug 2 2017, 8:52 PM
durin42 accepted this revision.Aug 4 2017, 5:35 PM
durin42 added a subscriber: durin42.

Sure.

This revision is now accepted and ready to land.Aug 4 2017, 5:35 PM
Closed by commit rHG40cfe3197bc1: phabricator: add --confirm option to phabsend command (authored by pulkit). · Explain WhyAug 4 2017, 5:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/phabricator.py (31 lines)

Diff 562

contrib/phabricator.py

unresolved = set(names) - resolved unresolved = set(names) - resolved
if unresolved: if unresolved:
raise error.Abort(_('unknown username: %s') raise error.Abort(_('unknown username: %s')
% ' '.join(sorted(unresolved))) % ' '.join(sorted(unresolved)))
return [entry[r'phid'] for entry in data] return [entry[r'phid'] for entry in data]
@command('phabsend', @command('phabsend',
[('r', 'rev', [], _('revisions to send'), _('REV')), [('r', 'rev', [], _('revisions to send'), _('REV')),
('', 'reviewer', [], _('specify reviewers'))], ('', 'reviewer', [], _('specify reviewers')),
('', 'confirm', None, _('ask for confirmation before sending'))],
_('REV [OPTIONS]')) _('REV [OPTIONS]'))
def phabsend(ui, repo, *revs, **opts): def phabsend(ui, repo, *revs, **opts):
"""upload changesets to Phabricator """upload changesets to Phabricator
If there are multiple revisions specified, they will be send as a stack If there are multiple revisions specified, they will be send as a stack
with a linear dependencies relationship using the order specified by the with a linear dependencies relationship using the order specified by the
revset. revset.
For the first time uploading changesets, local tags will be created to For the first time uploading changesets, local tags will be created to
maintain the association. After the first time, phabsend will check maintain the association. After the first time, phabsend will check
obsstore and tags information so it can figure out whether to update an obsstore and tags information so it can figure out whether to update an
existing Differential Revision, or create a new one. existing Differential Revision, or create a new one.
The --confirm option lets you confirm changesets before sending them. You
can also add following to your configuration file to make it default
behaviour.
[phabsend]
confirm = true
""" """
revs = list(revs) + opts.get('rev', []) revs = list(revs) + opts.get('rev', [])
revs = scmutil.revrange(repo, revs) revs = scmutil.revrange(repo, revs)
if not revs: if not revs:
raise error.Abort(_('phabsend requires at least one changeset')) raise error.Abort(_('phabsend requires at least one changeset'))
confirm = ui.configbool('phabsend', 'confirm')
confirm |= bool(opts.get('confirm'))
if confirm:
confirmed = _confirmbeforesend(repo, revs)
if not confirmed:
raise error.Abort(_('phabsend cancelled'))
actions = [] actions = []
reviewers = opts.get('reviewer', []) reviewers = opts.get('reviewer', [])
if reviewers: if reviewers:
phids = userphids(repo, reviewers) phids = userphids(repo, reviewers)
actions.append({'type': 'reviewers.add', 'value': phids}) actions.append({'type': 'reviewers.add', 'value': phids})
oldnodedrev = getoldnodedrevmap(repo, [repo[r].node() for r in revs]) oldnodedrev = getoldnodedrevmap(repo, [repo[r].node() for r in revs])
ctx.description().split('\n')[0])) ctx.description().split('\n')[0]))
lastrevid = newrevid lastrevid = newrevid
# Map from "hg:meta" keys to header understood by "hg import". The order is # Map from "hg:meta" keys to header understood by "hg import". The order is
# consistent with "hg export" output. # consistent with "hg export" output.
_metanamemap = util.sortdict([(r'user', 'User'), (r'date', 'Date'), _metanamemap = util.sortdict([(r'user', 'User'), (r'date', 'Date'),
(r'node', 'Node ID'), (r'parent', 'Parent ')]) (r'node', 'Node ID'), (r'parent', 'Parent ')])
def _confirmbeforesend(repo, revs):
ui = repo.ui
for rev in revs:
ctx = repo[rev]
desc = ctx.description().splitlines()[0]
ui.write(('%d: ' % rev), label='phabsend.revnumber')
ui.write(('%s\n' % desc), label='phabsend.desc')
if ui.promptchoice(_('Phabsend the above changes (yn)?'
'$$ &Yes $$ &No')):
return False
return True
def querydrev(repo, params, stack=False): def querydrev(repo, params, stack=False):
"""return a list of "Differential Revision" dicts """return a list of "Differential Revision" dicts
params is the input of "differential.query" API, and is expected to match params is the input of "differential.query" API, and is expected to match
just a single Differential Revision. just a single Differential Revision.
A "Differential Revision dict" looks like: A "Differential Revision dict" looks like: