Page MenuHomePhabricator

crdump: fix tests on OSX
ClosedPublic

Authored by mitrandir on Aug 3 2017, 11:44 AM.

Details

Reviewers
ryanmce
ikostia
Group Reviewers
Restricted Project
Commits
rFBHGXbb367daf87df: crdump: fix tests on OSX
Summary

We need a check-code for that. "echo -e" prints "-e" on OSX

Test Plan

tested on my laptop

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mitrandir created this revision.Aug 3 2017, 11:44 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 3 2017, 11:44 AM
ryanmce accepted this revision.Aug 3 2017, 11:47 AM
This revision is now accepted and ready to land.Aug 3 2017, 11:47 AM
ikostia accepted this revision.Aug 3 2017, 11:47 AM
ikostia added a subscriber: ikostia.

Can you explain why exactly the old approach failed on OSX in the summary?

mitrandir edited the summary of this revision. (Show Details)Aug 3 2017, 11:50 AM
This revision was automatically updated to reflect the committed changes.