This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2361

remotenames: don't inherit the remotenames class from dict class
ClosedPublic

Authored by pulkit on Feb 21 2018, 4:50 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG1bd132a021dd: remotenames: don't inherit the remotenames class from dict class
Summary

The remotenames class was moved from hgremotenames extension. The class in
hgremotenames extension used to extend dict because updating bookmark was done
through a dict-like interface or Sean (smf) wanted it to be that way.
But now, we can remove the inheritance from the dict class as updating bookmark
is not done using a dict-like interface.

Thanks to Martin von Zweigbergk for spotting this.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 21 2018, 4:50 AM
yuja accepted this revision.Feb 27 2018, 7:47 PM
This revision is now accepted and ready to land.Feb 27 2018, 7:47 PM
Closed by commit rHG1bd132a021dd: remotenames: don't inherit the remotenames class from dict class (authored by pulkit). · Explain WhyFeb 27 2018, 8:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/remotenames.py (11 lines)

Diff 6186

hgext/remotenames.py

""" Iterate over (name, node) tuples """ """ Iterate over (name, node) tuples """
if not self.loaded: if not self.loaded:
self._load() self._load()
for k, vtup in self.potentialentries.iteritems(): for k, vtup in self.potentialentries.iteritems():
yield (k, [bin(vtup[0])]) yield (k, [bin(vtup[0])])
class remotenames(dict): class remotenames(object):
""" """
This class encapsulates all the remotenames state. It also contains This class encapsulates all the remotenames state. It also contains
methods to access that state in convenient ways. Remotenames are lazy methods to access that state in convenient ways. Remotenames are lazy
loaded. Whenever client code needs to ensure the freshest copy of loaded. Whenever client code needs to ensure the freshest copy of
remotenames, use the `clearnames` method to force an eventual load. remotenames, use the `clearnames` method to force an eventual load.
""" """
def __init__(self, repo, *args): def __init__(self, repo, *args):
dict.__init__(self, *args)
self._repo = repo self._repo = repo
self.clearnames() self.clearnames()
def clearnames(self): def clearnames(self):
""" Clear all remote names state """ """ Clear all remote names state """
self['bookmarks'] = lazyremotenamedict("bookmarks", self._repo) self.bookmarks = lazyremotenamedict("bookmarks", self._repo)
self['branches'] = lazyremotenamedict("branches", self._repo) self.branches = lazyremotenamedict("branches", self._repo)
self._invalidatecache() self._invalidatecache()
def _invalidatecache(self): def _invalidatecache(self):
self._nodetobmarks = None self._nodetobmarks = None
self._nodetobranch = None self._nodetobranch = None
def bmarktonodes(self): def bmarktonodes(self):
return self['bookmarks'] return self.bookmarks
def nodetobmarks(self): def nodetobmarks(self):
if not self._nodetobmarks: if not self._nodetobmarks:
bmarktonodes = self.bmarktonodes() bmarktonodes = self.bmarktonodes()
self._nodetobmarks = {} self._nodetobmarks = {}
for name, node in bmarktonodes.iteritems(): for name, node in bmarktonodes.iteritems():
self._nodetobmarks.setdefault(node[0], []).append(name) self._nodetobmarks.setdefault(node[0], []).append(name)
return self._nodetobmarks return self._nodetobmarks
def branchtonodes(self): def branchtonodes(self):
return self['branches'] return self.branches
def nodetobranch(self): def nodetobranch(self):
if not self._nodetobranch: if not self._nodetobranch:
branchtonodes = self.branchtonodes() branchtonodes = self.branchtonodes()
self._nodetobranch = {} self._nodetobranch = {}
for name, nodes in branchtonodes.iteritems(): for name, nodes in branchtonodes.iteritems():
for node in nodes: for node in nodes:
self._nodetobranch.setdefault(node, []).append(name) self._nodetobranch.setdefault(node, []).append(name)