This is an archive of the discontinued Mercurial Phabricator instance.

py3: slice over bytes or use .startswith() to prevent getting ascii values
ClosedPublic

Authored by pulkit on Feb 26 2018, 7:32 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Feb 26 2018, 7:32 AM
yuja requested changes to this revision.Feb 26 2018, 8:21 AM
yuja added a subscriber: yuja.
yuja added inline comments.
mercurial/patch.py
2521

Nit: could be token.startswith('\t')

This revision now requires changes to proceed.Feb 26 2018, 8:21 AM
pulkit retitled this revision from py3: slice over bytes to prevent getting ascii values to py3: slice over bytes or use .startswith() to prevent getting ascii values.Feb 26 2018, 1:52 PM
pulkit updated this revision to Diff 6127.
yuja accepted this revision.Feb 27 2018, 7:07 AM
This revision is now accepted and ready to land.Feb 27 2018, 7:07 AM
This revision was automatically updated to reflect the committed changes.