This is an archive of the discontinued Mercurial Phabricator instance.

graft: move logic to read current graft state file in separate function
AbandonedPublic

Authored by pulkit on Mar 3 2018, 2:19 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

The logic to read the current graft state format is moved in a separate function
so that can be used in future when we need to fallback reading to current graft
state.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Mar 3 2018, 2:19 PM
pulkit updated this revision to Diff 6619.Mar 4 2018, 4:29 PM
pulkit updated this revision to Diff 6760.Mar 9 2018, 5:55 AM
pulkit updated this revision to Diff 7022.Mar 14 2018, 4:55 AM
pulkit updated this revision to Diff 7106.Mar 19 2018, 9:28 AM
martinvonz added inline comments.
mercurial/state.py
117–120 ↗(On Diff #7106)

Shouldn't this code be in commands.py? I don't think we should centralize the code for parsing all old formats in state.py. That will not happen with third-party extensions anyway, of course.

pulkit added inline comments.Mar 26 2018, 11:10 AM
mercurial/state.py
117–120 ↗(On Diff #7106)

No strong reason to have it here. I will move it in commands.py.

pulkit edited the summary of this revision. (Show Details)Mar 26 2018, 1:09 PM
pulkit retitled this revision from graft: move logic to read current graft state file in state.py to graft: move logic to read current graft state file in separate function.
pulkit updated this revision to Diff 7301.
pulkit abandoned this revision.May 25 2018, 4:56 PM

Superseded by D3651.