( )⚙ D2634 [DRAFT] xdiff: avoid hashing trimmed lines

This is an archive of the discontinued Mercurial Phabricator instance.

[DRAFT] xdiff: avoid hashing trimmed lines
AbandonedPublic

Authored by quark on Mar 3 2018, 11:21 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

Things are a bit faster now:

hg perfbdiff --count 3000 --blocks --xdiff .hg/store/data/mercurial/commands.py.i 1
# before
! wall 1.510821 comb 1.500000 user 1.500000 sys 0.000000 (best of 6)
# after
! wall 1.025628 comb 1.020000 user 1.020000 sys 0.000000 (best of 8)

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Mar 3 2018, 11:21 PM
quark abandoned this revision.Mar 4 2018, 7:50 PM

D2686 is a better fix