( )⚙ D2639 thirdparty: start vendoring cbor python library

This is an archive of the discontinued Mercurial Phabricator instance.

thirdparty: start vendoring cbor python library
AbandonedPublic

Authored by pulkit on Mar 4 2018, 11:11 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

CBOR stands for Concise Binary Object Representation, which is a data format
which is very compact and extensible.

This patch moves the python library which can serilaize and deserialize python
objects to/from cbor formats. The library is taken from
https://github.com/brianolson/cbor_py/ and files are taken from version 1.0.0.

The library is not used yet and there are some test-check* fails all of which
will be fixed in the next patch.

I wanted to keep this commit to just import the library.

One thing is changed while importing things is removing Carriage returns from
README.md

  1. no-check-commit because we are importing a third party library

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Mar 4 2018, 11:11 AM
pulkit added a comment.Mar 9 2018, 6:01 AM

The library imported in this patch has known bugs and can result in segfaults when given nested structures. Also this library is unmaintained and does not supports sets. Therefore, we import a better maintained library which handles all the cases pretty well. This is superseded by D2750.

pulkit abandoned this revision.Mar 9 2018, 6:01 AM