This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2642

util: also silence py3 warnings from codec module
ClosedPublic

Authored by durin42 on Mar 4 2018, 11:55 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHGaa9c5d447980: util: also silence py3 warnings from codec module
Summary

Fixes warnings like this:

+ mercurial/util.py:2446: DeprecationWarning: invalid escape sequence '\d'
+ return codecs.escape_decode(s)[0]

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Mar 4 2018, 11:55 AM
yuja accepted this revision.Mar 4 2018, 12:03 PM
This revision is now accepted and ready to land.Mar 4 2018, 12:03 PM
Closed by commit rHGaa9c5d447980: util: also silence py3 warnings from codec module (authored by durin42). · Explain WhyMar 4 2018, 12:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/util.py (2 lines)

Diff 6560

mercurial/util.py

# makes the whole PYTHONWARNINGS thing useless for our usecase. # makes the whole PYTHONWARNINGS thing useless for our usecase.
warnings.filterwarnings(r'default', r'', DeprecationWarning, r'mercurial') warnings.filterwarnings(r'default', r'', DeprecationWarning, r'mercurial')
warnings.filterwarnings(r'default', r'', DeprecationWarning, r'hgext') warnings.filterwarnings(r'default', r'', DeprecationWarning, r'hgext')
warnings.filterwarnings(r'default', r'', DeprecationWarning, r'hgext3rd') warnings.filterwarnings(r'default', r'', DeprecationWarning, r'hgext3rd')
if _dowarn and pycompat.ispy3: if _dowarn and pycompat.ispy3:
# silence warning emitted by passing user string to re.sub() # silence warning emitted by passing user string to re.sub()
warnings.filterwarnings(r'ignore', r'bad escape', DeprecationWarning, warnings.filterwarnings(r'ignore', r'bad escape', DeprecationWarning,
r'mercurial') r'mercurial')
warnings.filterwarnings(r'ignore', r'invalid escape sequence',
DeprecationWarning, r'mercurial')
def nouideprecwarn(msg, version, stacklevel=1): def nouideprecwarn(msg, version, stacklevel=1):
"""Issue an python native deprecation warning """Issue an python native deprecation warning
This is a noop outside of tests, use 'ui.deprecwarn' when possible. This is a noop outside of tests, use 'ui.deprecwarn' when possible.
""" """
if _dowarn: if _dowarn:
msg += ("\n(compatibility will be dropped after Mercurial-%s," msg += ("\n(compatibility will be dropped after Mercurial-%s,"