This is an archive of the discontinued Mercurial Phabricator instance.

Differential D265

exchange: access requirements on repo instead of peer
ClosedPublic

Authored by indygreg on Aug 7 2017, 11:24 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG033484935391: exchange: access requirements on repo instead of peer
Summary

As part of formalizing the peer interface, I audited for attribute
accesses for non-internal names to find API violations. This
uncovered the code changed in this commit.

localpeer.requirements is just an alias to the repo's requirements
attribute. So, change the code to get the data from the source
instead of relying on a one-off attribute in the localpeer type.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/exchange.py (6 lines)

Diff 629

mercurial/exchange.py

configuration for preferring stream clones. configuration for preferring stream clones.
Returns the ``pulloperation`` created for this pull. Returns the ``pulloperation`` created for this pull.
""" """
if opargs is None: if opargs is None:
opargs = {} opargs = {}
pullop = pulloperation(repo, remote, heads, force, bookmarks=bookmarks, pullop = pulloperation(repo, remote, heads, force, bookmarks=bookmarks,
streamclonerequested=streamclonerequested, **opargs) streamclonerequested=streamclonerequested, **opargs)
if pullop.remote.local():
missing = set(pullop.remote.requirements) - pullop.repo.supported peerlocal = pullop.remote.local()
if peerlocal:
missing = set(peerlocal.requirements) - pullop.repo.supported
if missing: if missing:
msg = _("required features are not" msg = _("required features are not"
" supported in the destination:" " supported in the destination:"
" %s") % (', '.join(sorted(missing))) " %s") % (', '.join(sorted(missing)))
raise error.Abort(msg) raise error.Abort(msg)
wlock = lock = None wlock = lock = None
try: try: