This is an archive of the discontinued Mercurial Phabricator instance.

Differential D269

dirstate: simplify and speed up dirstate's __iter__
ClosedPublic

Authored by alex_gaynor on Aug 8 2017, 2:53 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG36d216dcae6a: dirstate: simplify dirstate's __iter__

Diff Detail

Repository
rHG Mercurial
Branch
simplify-iter (bookmark) on default (branch)
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

alex_gaynor created this revision.Aug 8 2017, 2:53 PM
durin42 accepted this revision.Aug 8 2017, 4:26 PM
This revision is now accepted and ready to land.Aug 8 2017, 4:26 PM
Closed by commit rHG36d216dcae6a: dirstate: simplify dirstate's __iter__ (authored by alex_gaynor). · Explain WhyAug 8 2017, 4:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstate.py (3 lines)

Diff 634

mercurial/dirstate.py

? not tracked ? not tracked
''' '''
return self._map.get(key, ("?",))[0] return self._map.get(key, ("?",))[0]
def __contains__(self, key): def __contains__(self, key):
return key in self._map return key in self._map
def __iter__(self): def __iter__(self):
for x in sorted(self._map): return iter(sorted(self._map))
yield x
def items(self): def items(self):
return self._map.iteritems() return self._map.iteritems()
iteritems = items iteritems = items
def parents(self): def parents(self):
return [self._validate(p) for p in self._pl] return [self._validate(p) for p in self._pl]