This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2704

archival: fileit should not use atomictemp, causes major performance regression
ClosedPublic

Authored by vincent.parrett on Mar 6 2018, 5:09 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGa148c67d8b09: archival: fileit should not use atomictemp, causes performance regression

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vincent.parrett created this revision.Mar 6 2018, 5:09 PM
vincent.parrett added a comment.Mar 6 2018, 5:18 PM

This change results in around a 20% performance increase when archiving to a folder.

durin42 accepted this revision.Mar 7 2018, 10:55 AM
This revision is now accepted and ready to land.Mar 7 2018, 10:55 AM
Closed by commit rHGa148c67d8b09: archival: fileit should not use atomictemp, causes performance regression (authored by vincent.parrett). · Explain WhyMar 7 2018, 11:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/archival.py (2 lines)

Diff 6692

mercurial/archival.py

self.basedir = name self.basedir = name
self.opener = vfsmod.vfs(self.basedir) self.opener = vfsmod.vfs(self.basedir)
self.mtime = mtime self.mtime = mtime
def addfile(self, name, mode, islink, data): def addfile(self, name, mode, islink, data):
if islink: if islink:
self.opener.symlink(data, name) self.opener.symlink(data, name)
return return
f = self.opener(name, "w", atomictemp=True) f = self.opener(name, "w", atomictemp=False)
f.write(data) f.write(data)
f.close() f.close()
destfile = os.path.join(self.basedir, name) destfile = os.path.join(self.basedir, name)
os.chmod(destfile, mode) os.chmod(destfile, mode)
if self.mtime is not None: if self.mtime is not None:
os.utime(destfile, (self.mtime, self.mtime)) os.utime(destfile, (self.mtime, self.mtime))
def done(self): def done(self):