This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2882

hgweb: convert an assert to a ProgrammingError
ClosedPublic

Authored by indygreg on Mar 16 2018, 3:15 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGa82fc3922446: hgweb: convert an assert to a ProgrammingError
Summary

Because assert may get optimized away.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 16 2018, 3:15 PM
pulkit accepted this revision.Mar 17 2018, 2:06 PM
Closed by commit rHGa82fc3922446: hgweb: convert an assert to a ProgrammingError (authored by indygreg). · Explain WhyMar 17 2018, 3:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hgweb/webcommands.py (4 lines)

Diff 7095

mercurial/hgweb/webcommands.py

web.res.headers['Content-Type'] = mimetype web.res.headers['Content-Type'] = mimetype
web.res.headers['Content-Disposition'] = 'attachment; filename=%s%s' % ( web.res.headers['Content-Disposition'] = 'attachment; filename=%s%s' % (
name, extension) name, extension)
if encoding: if encoding:
web.res.headers['Content-Encoding'] = encoding web.res.headers['Content-Encoding'] = encoding
web.res.setbodywillwrite() web.res.setbodywillwrite()
assert list(web.res.sendresponse()) == [] if list(web.res.sendresponse()):
raise error.ProgrammingError('sendresponse() should not emit data '
'if writing later')
bodyfh = web.res.getbodyfile() bodyfh = web.res.getbodyfile()
archival.archive(web.repo, bodyfh, cnode, artype, prefix=name, archival.archive(web.repo, bodyfh, cnode, artype, prefix=name,
matchfn=match, matchfn=match,
subrepos=web.configbool("web", "archivesubrepos")) subrepos=web.configbool("web", "archivesubrepos"))
return [] return []